Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1014)

Issue 2887183005: Don't update the save card bubble icon once the browser isn't available. (Closed)

Created:
11 months, 1 week ago by Justin Donnelly
Modified:
11 months, 1 week ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't update the save card bubble icon once the browser isn't available. If a tab showing the save credit card buble is closed while the bubble is still visible, the bubble will attempt to update the icon in the location bar. Because the browser object is no longer available, this causes a crash. Note that this doesn't happen in the common case where the user closes the tab by clicking on the tab close icon (x) because that action closes the bubble first. But if the user closes the tab via a keyboard shortcut or a page closes a child tab via javascript, then the crash occurs. BUG=694188 Review-Url: https://codereview.chromium.org/2887183005 Cr-Commit-Position: refs/heads/master@{#473353} Committed: https://chromium.googlesource.com/chromium/src/+/045ea5cd8deddecd726b94229d9e59bb7c3d804f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Justin Donnelly
11 months, 1 week ago (2017-05-19 18:40:41 UTC) #6
Mathieu
lgtm
11 months, 1 week ago (2017-05-19 19:54:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887183005/1
11 months, 1 week ago (2017-05-19 21:35:25 UTC) #11
commit-bot: I haz the power
11 months, 1 week ago (2017-05-19 22:13:55 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/045ea5cd8deddecd726b94229d9e...

Powered by Google App Engine
This is Rietveld 408576698