Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Issue 2887183004: Ensure that remoting_unittests fail when playout delay > 0. (Closed)

Created:
3 years, 7 months ago by Sergey Ulanov
Modified:
3 years, 7 months ago
Reviewers:
Jamie
CC:
chromium-reviews, posciak+watch_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure that remoting_unittests fail when playout delay > 0. Added NOTREACHED() WebrtcVideoRendererAdapter for the case when playout delay > 0. Also updated ConnectionTest_Video to receive 5 tests. With this change remoting_unittests will fail if playout delay extension is not sent by the host or is ignored on the receiving side. This will help to prevent regressions like crbug.com/webrtc/7590 in the future. Previously the adapter was only logging a warning in that case. BUG=722490 Review-Url: https://codereview.chromium.org/2887183004 Cr-Commit-Position: refs/heads/master@{#473323} Committed: https://chromium.googlesource.com/chromium/src/+/69008afaa78dd9d2fc012b3fcb8f2e0a56fc0a1d

Patch Set 1 : . #

Patch Set 2 : fix failure on windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M remoting/protocol/connection_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M remoting/protocol/webrtc_video_renderer_adapter.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Sergey Ulanov
3 years, 7 months ago (2017-05-18 19:51:20 UTC) #3
Jamie
lgtm
3 years, 7 months ago (2017-05-18 21:49:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887183004/20001
3 years, 7 months ago (2017-05-18 21:53:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/449135)
3 years, 7 months ago (2017-05-19 02:14:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887183004/40001
3 years, 7 months ago (2017-05-19 20:49:16 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 21:21:53 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/69008afaa78dd9d2fc012b3fcb8f...

Powered by Google App Engine
This is Rietveld 408576698