Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2887183002: [DevTools] Fix Application Panel initial selection (Closed)

Created:
3 years, 7 months ago by eostroukhov
Modified:
3 years, 7 months ago
Reviewers:
caseq, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix Application Panel initial selection 1. Select manifest panel if there's no stored selection. 2. Fix selection restoration for the top-level tree items. 3. Parent element will now be selected if selection cannot be restored because the element have been gone from the tree. BUG=722716 Review-Url: https://codereview.chromium.org/2887183002 Cr-Commit-Position: refs/heads/master@{#472874} Committed: https://chromium.googlesource.com/chromium/src/+/d0471f6d597b98fb255a0190751c9ccc0636d09e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js View 4 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
eostroukhov
3 years, 7 months ago (2017-05-17 19:24:34 UTC) #2
dgozman
lgtm
3 years, 7 months ago (2017-05-17 21:03:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887183002/1
3 years, 7 months ago (2017-05-17 21:25:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/458031)
3 years, 7 months ago (2017-05-18 00:14:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887183002/1
3 years, 7 months ago (2017-05-18 15:38:18 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 18:14:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d0471f6d597b98fb255a0190751c...

Powered by Google App Engine
This is Rietveld 408576698