Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 2887153008: Avoid CFI error due to SiteInstanceImpl::GetProcess change. (Closed)

Created:
3 years, 7 months ago by Charlie Reis
Modified:
3 years, 7 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, jam, ajwong+watch_chromium.org, clamy
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid CFI error due to SiteInstanceImpl::GetProcess change. This short-circuits a conditional the way it used to be, avoiding a bad cast in a unit test. BUG=721975 TEST=CFI bot goes green. Review-Url: https://codereview.chromium.org/2887153008 Cr-Commit-Position: refs/heads/master@{#473366} Committed: https://chromium.googlesource.com/chromium/src/+/a9f04baa366660121d53d211df8d30b43b42e796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/site_instance_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Charlie Reis
Nasko, can you take a look? Explanation is in https://crbug.com/721975#c3.
3 years, 7 months ago (2017-05-19 21:10:16 UTC) #2
nasko
LGTM
3 years, 7 months ago (2017-05-19 21:25:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887153008/1
3 years, 7 months ago (2017-05-19 21:30:05 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 22:28:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a9f04baa366660121d53d211df8d...

Powered by Google App Engine
This is Rietveld 408576698