Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2887153005: [logdog-stream-view] Auth and misc bugfixes. (Closed)

Created:
3 years, 7 months ago by dnj
Modified:
3 years, 7 months ago
Reviewers:
hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[logdog-stream-view] Auth and misc bugfixes. Fix failure to re-attempt log fetching after authentication has completed. Now that operations are intent-scoped instead of fetch-scoped, cancelling operations after an auth failure makes no sense, and prevents a retry from succeeding. Fix missing arrow icons on middle split buttons. Fix broken handle link. TBR=hinoka@chromium.org BUG=chromium:724014 TEST=local - Ran in "dev" production instance to verify auth. - Ran locally. Review-Url: https://codereview.chromium.org/2887153005 Committed: https://github.com/luci/luci-go/commit/7b3df3552a59e407f36849d64a258812da008aad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M web/inc/logdog-stream-view/logdog-stream-view.html View 3 chunks +4 lines, -2 lines 0 comments Download
M web/inc/logdog-stream-view/model.ts View 2 chunks +2 lines, -1 line 0 comments Download
M web/inc/logdog-stream-view/view.ts View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887153005/1
3 years, 7 months ago (2017-05-18 17:17:09 UTC) #2
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 17:24:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/7b3df3552a59e407f36849d64a258812da008aad

Powered by Google App Engine
This is Rietveld 408576698