Adds address normalization to iOS.

Adds address normalization to iOS.

BUG=602666
Review-Url: https://codereview.chromium.org/2887123002
Cr-Commit-Position: refs/heads/master@{#472924}
Committed: https://chromium.googlesource.com/chromium/src/+/bf190e9035d5f02845664f0fd938739351ed97a5

[macourteau, 2017-05-17 15:38:31]

macourteau@chromium.org changed reviewers:
+ mahmadi@chromium.org

[macourteau, 2017-05-17 15:38:36]

The CQ bit was checked by macourteau@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 15:39:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[macourteau, 2017-05-17 15:51:18]

The CQ bit was checked by macourteau@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 15:51:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 16:46:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 16:46:01]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Moe, 2017-05-17 18:12:38]

LGTM!

https://codereview.chromium.org/2887123002/diff/60001/ios/chrome/browser/ui/p...
File ios/chrome/browser/ui/payments/payment_request_manager.mm (right):

https://codereview.chromium.org/2887123002/diff/60001/ios/chrome/browser/ui/p...
ios/chrome/browser/ui/payments/payment_request_manager.mm:635:
DCHECK_EQ(_paymentRequest.get(), paymentRequest);
nit: I prefer if |paymentRequest| wasn't part of the arguments because there's
only one instance circulating around. You could change the method signature to
something like the following without losing meaning:
-paymentRequestCoordinator:didCompletePaymentRequestWithCard:verificationCode:

[macourteau, 2017-05-17 19:15:16]

https://codereview.chromium.org/2887123002/diff/60001/ios/chrome/browser/ui/p...
File ios/chrome/browser/ui/payments/payment_request_manager.mm (right):

https://codereview.chromium.org/2887123002/diff/60001/ios/chrome/browser/ui/p...
ios/chrome/browser/ui/payments/payment_request_manager.mm:635:
DCHECK_EQ(_paymentRequest.get(), paymentRequest);
On 2017/05/17 18:12:38, Moe wrote:
> nit: I prefer if |paymentRequest| wasn't part of the arguments because there's
> only one instance circulating around. You could change the method signature to
> something like the following without losing meaning:
> -paymentRequestCoordinator:didCompletePaymentRequestWithCard:verificationCode:

Done.

[Moe, 2017-05-17 20:34:18]

On 2017/05/17 19:15:16, macourteau wrote:
>
https://codereview.chromium.org/2887123002/diff/60001/ios/chrome/browser/ui/p...
> File ios/chrome/browser/ui/payments/payment_request_manager.mm (right):
> 
>
https://codereview.chromium.org/2887123002/diff/60001/ios/chrome/browser/ui/p...
> ios/chrome/browser/ui/payments/payment_request_manager.mm:635:
> DCHECK_EQ(_paymentRequest.get(), paymentRequest);
> On 2017/05/17 18:12:38, Moe wrote:
> > nit: I prefer if |paymentRequest| wasn't part of the arguments because
there's
> > only one instance circulating around. You could change the method signature
to
> > something like the following without losing meaning:
> >
-paymentRequestCoordinator:didCompletePaymentRequestWithCard:verificationCode:
> 
> Done.

still LGTM.

[macourteau, 2017-05-18 14:42:18]

Updated as discussed in person (patchset #7). PTAL.

[macourteau, 2017-05-18 14:42:22]

The CQ bit was checked by macourteau@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 14:42:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2017-05-18 15:21:43]

still lgtm % nits

https://codereview.chromium.org/2887123002/diff/120001/ios/chrome/browser/ui/...
File ios/chrome/browser/ui/payments/payment_request_manager.mm (right):

https://codereview.chromium.org/2887123002/diff/120001/ios/chrome/browser/ui/...
ios/chrome/browser/ui/payments/payment_request_manager.mm:657:
*_paymentRequest->selected_shipping_profile();
nit 1: DCHECK before dereferencing.
nit 2: the TODO below could probably be moved before the DCHECK.

https://codereview.chromium.org/2887123002/diff/120001/ios/chrome/browser/ui/...
ios/chrome/browser/ui/payments/payment_request_manager.mm:663:
*_paymentRequest->selected_contact_profile();
nit 1: you should probably check if either phone number, name, or email are
requested similar to what's being done for the shipping address above.
nit 2: DCHECK before dereferencing.
nit 3: those TODOs below could probably move before the DCHECK.

[macourteau, 2017-05-18 15:44:54]

https://codereview.chromium.org/2887123002/diff/120001/ios/chrome/browser/ui/...
File ios/chrome/browser/ui/payments/payment_request_manager.mm (right):

https://codereview.chromium.org/2887123002/diff/120001/ios/chrome/browser/ui/...
ios/chrome/browser/ui/payments/payment_request_manager.mm:657:
*_paymentRequest->selected_shipping_profile();
On 2017/05/18 15:21:43, Moe wrote:
> nit 1: DCHECK before dereferencing.
> nit 2: the TODO below could probably be moved before the DCHECK.

Done.

https://codereview.chromium.org/2887123002/diff/120001/ios/chrome/browser/ui/...
ios/chrome/browser/ui/payments/payment_request_manager.mm:663:
*_paymentRequest->selected_contact_profile();
On 2017/05/18 15:21:43, Moe wrote:
> nit 1: you should probably check if either phone number, name, or email are
> requested similar to what's being done for the shipping address above.
> nit 2: DCHECK before dereferencing.
> nit 3: those TODOs below could probably move before the DCHECK.

Done.

[macourteau, 2017-05-18 16:17:19]

The CQ bit was checked by macourteau@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 16:18:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 17:53:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 17:53:42]

Dry run: This issue passed the CQ dry run.

[macourteau, 2017-05-18 20:42:37]

The CQ bit was checked by macourteau@chromium.org

[macourteau, 2017-05-18 20:42:38]

The patchset sent to the CQ was uploaded after l-g-t-m from mahmadi@chromium.org
Link to the patchset: https://codereview.chromium.org/2887123002/#ps140001
(title: "Addresses nits from mahmadi@.")

[commit-bot: I haz the power, 2017-05-18 20:44:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 20:50:47]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1495140157838780,
"parent_rev": "ea63253fa4fdcf6db310bff500e72a8aac4ae8f9", "commit_rev":
"bf190e9035d5f02845664f0fd938739351ed97a5"}

[commit-bot: I haz the power, 2017-05-18 20:50:59]

Description was changed from

==========
Adds address normalization to iOS.

BUG=602666
==========

to

==========
Adds address normalization to iOS.

BUG=602666

Review-Url: https://codereview.chromium.org/2887123002
Cr-Commit-Position: refs/heads/master@{#472924}
Committed:
https://chromium.googlesource.com/chromium/src/+/bf190e9035d5f02845664f0fd938...
==========

[commit-bot: I haz the power, 2017-05-18 20:51:00]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/bf190e9035d5f02845664f0fd938...