Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1360)

Unified Diff: content/renderer/gpu/render_widget_compositor.cc

Issue 2887053002: Remove scroll_clip_layer dependency from viewport layer tracking (Closed)
Patch Set: Cleanup return stmt Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/gpu/render_widget_compositor.cc
diff --git a/content/renderer/gpu/render_widget_compositor.cc b/content/renderer/gpu/render_widget_compositor.cc
index 7730f139cce791cca4ffabc7fb83cdc26d6b2e9b..85638a1dcc21b5f8dd91ddb41d7c5e9ccf1021ba 100644
--- a/content/renderer/gpu/render_widget_compositor.cc
+++ b/content/renderer/gpu/render_widget_compositor.cc
@@ -779,31 +779,42 @@ void RenderWidgetCompositor::DidStopFlinging() {
void RenderWidgetCompositor::RegisterViewportLayers(
const blink::WebLayer* overscrollElasticityLayer,
const blink::WebLayer* pageScaleLayer,
+ const blink::WebLayer* innerViewportContainerLayer,
+ const blink::WebLayer* outerViewportContainerLayer,
const blink::WebLayer* innerViewportScrollLayer,
const blink::WebLayer* outerViewportScrollLayer) {
layer_tree_host_->RegisterViewportLayers(
// TODO(bokan): This check can probably be removed now, but it looks
- // like overscroll elasticity may still be NULL until VisualViewport
+ // like overscroll elasticity may still be nullptr until VisualViewport
// registers its layers.
overscrollElasticityLayer ? static_cast<const cc_blink::WebLayerImpl*>(
overscrollElasticityLayer)
->layer()
- : NULL,
+ : nullptr,
static_cast<const cc_blink::WebLayerImpl*>(pageScaleLayer)->layer(),
+ innerViewportContainerLayer ? static_cast<const cc_blink::WebLayerImpl*>(
+ innerViewportContainerLayer)
+ ->layer()
+ : nullptr,
+ outerViewportContainerLayer ? static_cast<const cc_blink::WebLayerImpl*>(
+ outerViewportContainerLayer)
+ ->layer()
+ : nullptr,
static_cast<const cc_blink::WebLayerImpl*>(innerViewportScrollLayer)
->layer(),
// TODO(bokan): This check can probably be removed now, but it looks
- // like overscroll elasticity may still be NULL until VisualViewport
+ // like overscroll elasticity may still be nullptr until VisualViewport
// registers its layers.
outerViewportScrollLayer
? static_cast<const cc_blink::WebLayerImpl*>(outerViewportScrollLayer)
->layer()
- : NULL);
+ : nullptr);
}
void RenderWidgetCompositor::ClearViewportLayers() {
layer_tree_host_->RegisterViewportLayers(
scoped_refptr<cc::Layer>(), scoped_refptr<cc::Layer>(),
+ scoped_refptr<cc::Layer>(), scoped_refptr<cc::Layer>(),
scoped_refptr<cc::Layer>(), scoped_refptr<cc::Layer>());
}

Powered by Google App Engine
This is Rietveld 408576698