Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Side by Side Diff: content/renderer/gpu/render_widget_compositor.cc

Issue 2887053002: Remove scroll_clip_layer dependency from viewport layer tracking (Closed)
Patch Set: Cleanup return stmt Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/gpu/render_widget_compositor.h" 5 #include "content/renderer/gpu/render_widget_compositor.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <cmath> 9 #include <cmath>
10 #include <limits> 10 #include <limits>
(...skipping 761 matching lines...) Expand 10 before | Expand all | Expand 10 after
772 layer_tree_host_->SetNeedsAnimate(); 772 layer_tree_host_->SetNeedsAnimate();
773 } 773 }
774 774
775 void RenderWidgetCompositor::DidStopFlinging() { 775 void RenderWidgetCompositor::DidStopFlinging() {
776 layer_tree_host_->DidStopFlinging(); 776 layer_tree_host_->DidStopFlinging();
777 } 777 }
778 778
779 void RenderWidgetCompositor::RegisterViewportLayers( 779 void RenderWidgetCompositor::RegisterViewportLayers(
780 const blink::WebLayer* overscrollElasticityLayer, 780 const blink::WebLayer* overscrollElasticityLayer,
781 const blink::WebLayer* pageScaleLayer, 781 const blink::WebLayer* pageScaleLayer,
782 const blink::WebLayer* innerViewportContainerLayer,
783 const blink::WebLayer* outerViewportContainerLayer,
782 const blink::WebLayer* innerViewportScrollLayer, 784 const blink::WebLayer* innerViewportScrollLayer,
783 const blink::WebLayer* outerViewportScrollLayer) { 785 const blink::WebLayer* outerViewportScrollLayer) {
784 layer_tree_host_->RegisterViewportLayers( 786 layer_tree_host_->RegisterViewportLayers(
785 // TODO(bokan): This check can probably be removed now, but it looks 787 // TODO(bokan): This check can probably be removed now, but it looks
786 // like overscroll elasticity may still be NULL until VisualViewport 788 // like overscroll elasticity may still be nullptr until VisualViewport
787 // registers its layers. 789 // registers its layers.
788 overscrollElasticityLayer ? static_cast<const cc_blink::WebLayerImpl*>( 790 overscrollElasticityLayer ? static_cast<const cc_blink::WebLayerImpl*>(
789 overscrollElasticityLayer) 791 overscrollElasticityLayer)
790 ->layer() 792 ->layer()
791 : NULL, 793 : nullptr,
792 static_cast<const cc_blink::WebLayerImpl*>(pageScaleLayer)->layer(), 794 static_cast<const cc_blink::WebLayerImpl*>(pageScaleLayer)->layer(),
795 innerViewportContainerLayer ? static_cast<const cc_blink::WebLayerImpl*>(
796 innerViewportContainerLayer)
797 ->layer()
798 : nullptr,
799 outerViewportContainerLayer ? static_cast<const cc_blink::WebLayerImpl*>(
800 outerViewportContainerLayer)
801 ->layer()
802 : nullptr,
793 static_cast<const cc_blink::WebLayerImpl*>(innerViewportScrollLayer) 803 static_cast<const cc_blink::WebLayerImpl*>(innerViewportScrollLayer)
794 ->layer(), 804 ->layer(),
795 // TODO(bokan): This check can probably be removed now, but it looks 805 // TODO(bokan): This check can probably be removed now, but it looks
796 // like overscroll elasticity may still be NULL until VisualViewport 806 // like overscroll elasticity may still be nullptr until VisualViewport
797 // registers its layers. 807 // registers its layers.
798 outerViewportScrollLayer 808 outerViewportScrollLayer
799 ? static_cast<const cc_blink::WebLayerImpl*>(outerViewportScrollLayer) 809 ? static_cast<const cc_blink::WebLayerImpl*>(outerViewportScrollLayer)
800 ->layer() 810 ->layer()
801 : NULL); 811 : nullptr);
802 } 812 }
803 813
804 void RenderWidgetCompositor::ClearViewportLayers() { 814 void RenderWidgetCompositor::ClearViewportLayers() {
805 layer_tree_host_->RegisterViewportLayers( 815 layer_tree_host_->RegisterViewportLayers(
806 scoped_refptr<cc::Layer>(), scoped_refptr<cc::Layer>(), 816 scoped_refptr<cc::Layer>(), scoped_refptr<cc::Layer>(),
817 scoped_refptr<cc::Layer>(), scoped_refptr<cc::Layer>(),
807 scoped_refptr<cc::Layer>(), scoped_refptr<cc::Layer>()); 818 scoped_refptr<cc::Layer>(), scoped_refptr<cc::Layer>());
808 } 819 }
809 820
810 void RenderWidgetCompositor::RegisterSelection( 821 void RenderWidgetCompositor::RegisterSelection(
811 const blink::WebSelection& selection) { 822 const blink::WebSelection& selection) {
812 layer_tree_host_->RegisterSelection(ConvertWebSelection(selection)); 823 layer_tree_host_->RegisterSelection(ConvertWebSelection(selection));
813 } 824 }
814 825
815 void RenderWidgetCompositor::ClearSelection() { 826 void RenderWidgetCompositor::ClearSelection() {
816 cc::LayerSelection empty_selection; 827 cc::LayerSelection empty_selection;
(...skipping 395 matching lines...) Expand 10 before | Expand all | Expand 10 after
1212 const cc::LocalSurfaceId& local_surface_id) { 1223 const cc::LocalSurfaceId& local_surface_id) {
1213 layer_tree_host_->SetLocalSurfaceId(local_surface_id); 1224 layer_tree_host_->SetLocalSurfaceId(local_surface_id);
1214 } 1225 }
1215 1226
1216 void RenderWidgetCompositor::NotifySwapTime(ReportTimeCallback callback) { 1227 void RenderWidgetCompositor::NotifySwapTime(ReportTimeCallback callback) {
1217 QueueSwapPromise(base::MakeUnique<ReportTimeSwapPromise>( 1228 QueueSwapPromise(base::MakeUnique<ReportTimeSwapPromise>(
1218 std::move(callback), base::ThreadTaskRunnerHandle::Get())); 1229 std::move(callback), base::ThreadTaskRunnerHandle::Get()));
1219 } 1230 }
1220 1231
1221 } // namespace content 1232 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698