Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2887043003: Image Capture: reject setOptions()/applyConstraints() if any argument is unsupported (Closed)

Created:
3 years, 7 months ago by mcasas
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Image Capture: reject setOptions()/applyConstraints() if any argument is unsupported This CL adds rejection of applyConstraints()/setOptions() if the control value is out of ranges or unsupported, e.g. trying to set zoom to 1000 where the capability range is {1.0 - 10.0}. LayoutTests for each of those methods are added. BUG=718765 Review-Url: https://codereview.chromium.org/2877273002 Cr-Original-Commit-Position: refs/heads/master@{#472143} Review-Url: https://codereview.chromium.org/2887043003 . Cr-Commit-Position: refs/branch-heads/3071@{#605} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/eb3563bb431e6c26dace10a4b5325d4d4b812da5

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
mcasas
3 years, 7 months ago (2017-05-17 20:02:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eb3563bb431e6c26dace10a4b5325d4d4b812da5.

Powered by Google App Engine
This is Rietveld 408576698