Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: headless/app/headless_shell.h

Issue 2887033003: Add specific headless_shell_win.cc and headless_content_main_delegate_win.cc (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/app/headless_shell.h
diff --git a/headless/app/headless_shell.h b/headless/app/headless_shell.h
index c6411ca45583baec423d855292b119385cadaf92..e9d94f5799527723199281bc200a57a680c6d677 100644
--- a/headless/app/headless_shell.h
+++ b/headless/app/headless_shell.h
@@ -32,7 +32,7 @@ class HeadlessShell : public HeadlessWebContents::Observer,
HeadlessShell();
~HeadlessShell() override;
- void OnStart(HeadlessBrowser* browser);
+ virtual void OnStart(HeadlessBrowser* browser);
HeadlessDevToolsClient* devtools_client() const {
return devtools_client_.get();
@@ -40,7 +40,7 @@ class HeadlessShell : public HeadlessWebContents::Observer,
private:
// HeadlessWebContents::Observer implementation:
- void DevToolsTargetReady() override;
+ virtual void DevToolsTargetReady() override;
alex clarke (OOO till 29th) 2017/05/17 08:45:02 You shouldn't need both virtual and override. In f
void OnTargetCrashed(const inspector::TargetCrashedParams& params) override;
// emulation::Observer implementation:
@@ -52,7 +52,7 @@ class HeadlessShell : public HeadlessWebContents::Observer,
void OnNavigationRequested(
const headless::page::NavigationRequestedParams& params) override;
- void Shutdown();
+ virtual void Shutdown();
void FetchTimeout();

Powered by Google App Engine
This is Rietveld 408576698