Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2017 The Chromium Authors. All rights reserved. | 1 // Copyright 2017 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef HEADLESS_APP_HEADLESS_SHELL_H_ | 5 #ifndef HEADLESS_APP_HEADLESS_SHELL_H_ |
| 6 #define HEADLESS_APP_HEADLESS_SHELL_H_ | 6 #define HEADLESS_APP_HEADLESS_SHELL_H_ |
| 7 | 7 |
| 8 #include <memory> | 8 #include <memory> |
| 9 #include <string> | 9 #include <string> |
| 10 | 10 |
| (...skipping 14 matching lines...) Expand all Loading... | |
| 25 | 25 |
| 26 // An application which implements a simple headless browser. | 26 // An application which implements a simple headless browser. |
| 27 class HeadlessShell : public HeadlessWebContents::Observer, | 27 class HeadlessShell : public HeadlessWebContents::Observer, |
| 28 public emulation::ExperimentalObserver, | 28 public emulation::ExperimentalObserver, |
| 29 public inspector::ExperimentalObserver, | 29 public inspector::ExperimentalObserver, |
| 30 public page::ExperimentalObserver { | 30 public page::ExperimentalObserver { |
| 31 public: | 31 public: |
| 32 HeadlessShell(); | 32 HeadlessShell(); |
| 33 ~HeadlessShell() override; | 33 ~HeadlessShell() override; |
| 34 | 34 |
| 35 void OnStart(HeadlessBrowser* browser); | 35 virtual void OnStart(HeadlessBrowser* browser); |
| 36 | 36 |
| 37 HeadlessDevToolsClient* devtools_client() const { | 37 HeadlessDevToolsClient* devtools_client() const { |
| 38 return devtools_client_.get(); | 38 return devtools_client_.get(); |
| 39 } | 39 } |
| 40 | 40 |
| 41 private: | 41 private: |
| 42 // HeadlessWebContents::Observer implementation: | 42 // HeadlessWebContents::Observer implementation: |
| 43 void DevToolsTargetReady() override; | 43 virtual void DevToolsTargetReady() override; |
|
alex clarke (OOO till 29th)
2017/05/17 08:45:02
You shouldn't need both virtual and override. In f
| |
| 44 void OnTargetCrashed(const inspector::TargetCrashedParams& params) override; | 44 void OnTargetCrashed(const inspector::TargetCrashedParams& params) override; |
| 45 | 45 |
| 46 // emulation::Observer implementation: | 46 // emulation::Observer implementation: |
| 47 void OnVirtualTimeBudgetExpired( | 47 void OnVirtualTimeBudgetExpired( |
| 48 const emulation::VirtualTimeBudgetExpiredParams& params) override; | 48 const emulation::VirtualTimeBudgetExpiredParams& params) override; |
| 49 | 49 |
| 50 // page::Observer implementation: | 50 // page::Observer implementation: |
| 51 void OnLoadEventFired(const page::LoadEventFiredParams& params) override; | 51 void OnLoadEventFired(const page::LoadEventFiredParams& params) override; |
| 52 void OnNavigationRequested( | 52 void OnNavigationRequested( |
| 53 const headless::page::NavigationRequestedParams& params) override; | 53 const headless::page::NavigationRequestedParams& params) override; |
| 54 | 54 |
| 55 void Shutdown(); | 55 virtual void Shutdown(); |
| 56 | 56 |
| 57 void FetchTimeout(); | 57 void FetchTimeout(); |
| 58 | 58 |
| 59 void PollReadyState(); | 59 void PollReadyState(); |
| 60 | 60 |
| 61 void OnReadyState(std::unique_ptr<runtime::EvaluateResult> result); | 61 void OnReadyState(std::unique_ptr<runtime::EvaluateResult> result); |
| 62 | 62 |
| 63 void OnPageReady(); | 63 void OnPageReady(); |
| 64 | 64 |
| 65 void FetchDom(); | 65 void FetchDom(); |
| (...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 104 std::unique_ptr<base::FileProxy> file_proxy_; | 104 std::unique_ptr<base::FileProxy> file_proxy_; |
| 105 std::unique_ptr<DeterministicDispatcher> deterministic_dispatcher_; | 105 std::unique_ptr<DeterministicDispatcher> deterministic_dispatcher_; |
| 106 base::WeakPtrFactory<HeadlessShell> weak_factory_; | 106 base::WeakPtrFactory<HeadlessShell> weak_factory_; |
| 107 | 107 |
| 108 DISALLOW_COPY_AND_ASSIGN(HeadlessShell); | 108 DISALLOW_COPY_AND_ASSIGN(HeadlessShell); |
| 109 }; | 109 }; |
| 110 | 110 |
| 111 } // namespace headless | 111 } // namespace headless |
| 112 | 112 |
| 113 #endif // HEADLESS_APP_HEADLESS_SHELL_H_ | 113 #endif // HEADLESS_APP_HEADLESS_SHELL_H_ |
| OLD | NEW |