Create DomAgent and CSSAgent in Chrome.

Create DomAgent and CSSAgent in Chrome. When DevTools is moved out of
ash to Chrome, this will enables using DevTools in Window and Linux
platform.

BUG=711343
Review-Url: https://codereview.chromium.org/2887003003
Cr-Commit-Position: refs/heads/master@{#481653}
Committed: https://chromium.googlesource.com/chromium/src/+/a37a887a3612468ef05034aba0759e113d82e88a

[thanhph, 2017-06-01 19:03:08]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 19:04:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 19:26:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 19:26:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[thanhph, 2017-06-04 22:41:49]

Description was changed from

==========
Create DomAgent and CSSAgent in Chrome.

Create DomAgent and CSSAgent in Chrome. When DevTools is moved out of
ash to Chrome, this will enables using DevTools in Window and Linux
platform.

BUG=71143
==========

to

==========
Create DomAgent and CSSAgent in Chrome. When DevTools is moved out of
ash to Chrome, this will enables using DevTools in Window and Linux
platform.

BUG=71143
==========

[thanhph, 2017-06-04 22:41:57]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-04 22:42:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 01:03:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 01:03:45]

Dry run: This issue passed the CQ dry run.

[thanhph, 2017-06-12 14:45:20]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 14:45:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[thanhph, 2017-06-12 14:48:20]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 14:48:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 14:54:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 14:54:32]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[thanhph, 2017-06-12 14:59:54]

Patchset #11 (id:200001) has been deleted

[thanhph, 2017-06-12 14:59:59]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 15:00:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 16:41:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 16:41:09]

Dry run: This issue passed the CQ dry run.

[thanhph, 2017-06-13 05:22:14]

Patchset #12 (id:240001) has been deleted

[thanhph, 2017-06-13 05:22:32]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 05:22:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 06:21:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 06:21:40]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[thanhph, 2017-06-13 17:46:24]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 17:46:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 18:36:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 18:36:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[thanhph, 2017-06-13 21:12:25]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 21:13:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 22:54:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 22:54:40]

Dry run: This issue passed the CQ dry run.

[thanhph, 2017-06-14 14:14:59]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 14:15:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 14:17:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 14:17:57]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[thanhph, 2017-06-16 17:30:00]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 17:30:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 17:33:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 17:33:57]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[thanhph, 2017-06-21 18:00:35]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 18:00:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[thanhph, 2017-06-21 19:39:30]

Patchset #1 (id:1) has been deleted

[thanhph, 2017-06-21 19:39:42]

Patchset #1 (id:20001) has been deleted

[thanhph, 2017-06-21 19:39:51]

Patchset #1 (id:40001) has been deleted

[thanhph, 2017-06-21 19:40:01]

Patchset #1 (id:60001) has been deleted

[thanhph, 2017-06-21 19:40:18]

Patchset #1 (id:80001) has been deleted

[commit-bot: I haz the power, 2017-06-21 19:40:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 19:40:24]

Dry run: This issue passed the CQ dry run.

[thanhph, 2017-06-21 19:40:27]

Patchset #1 (id:100001) has been deleted

[thanhph, 2017-06-21 19:40:37]

Patchset #1 (id:120001) has been deleted

[thanhph, 2017-06-21 19:40:46]

Patchset #1 (id:140001) has been deleted

[thanhph, 2017-06-21 19:41:25]

Patchset #1 (id:160001) has been deleted

[thanhph, 2017-06-21 19:41:33]

Patchset #1 (id:180001) has been deleted

[thanhph, 2017-06-21 19:41:41]

Patchset #1 (id:220001) has been deleted

[thanhph, 2017-06-21 19:41:49]

Patchset #1 (id:260001) has been deleted

[thanhph, 2017-06-21 19:41:58]

Patchset #1 (id:280001) has been deleted

[thanhph, 2017-06-21 19:42:06]

Patchset #1 (id:300001) has been deleted

[thanhph, 2017-06-21 19:42:14]

Patchset #1 (id:320001) has been deleted

[thanhph, 2017-06-21 19:42:25]

Patchset #1 (id:340001) has been deleted

[thanhph, 2017-06-21 19:43:08]

thanhph@chromium.org changed reviewers:
+ sadrul@chromium.org

[thanhph, 2017-06-21 19:43:09]

Hi Sadrul,

Please review my new patch.

Thanks,
Thanh.

[sadrul, 2017-06-21 20:47:33]

You need review from ash/ and chrome/ owners, but lgtm

https://codereview.chromium.org/2887003003/diff/360001/chrome/browser/ui/view...
File chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h (right):

https://codereview.chromium.org/2887003003/diff/360001/chrome/browser/ui/view...
chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h:20: }
This should go below in USE_AURA #ifdef (i.e. line ~27)

[thanhph, 2017-06-21 21:49:06]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 21:49:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 23:10:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 23:10:56]

Dry run: This issue passed the CQ dry run.

[thanhph, 2017-06-21 23:22:45]

thanhph@chromium.org changed reviewers:
+ sky@chromium.org

[thanhph, 2017-06-21 23:22:46]

Thanks Sadrul.

Hi Scott,

Could you review my cl? I moved devtools out of ash/ and start it on chrome/

Thanks,
Thanh.

https://codereview.chromium.org/2887003003/diff/360001/chrome/browser/ui/view...
File chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h (right):

https://codereview.chromium.org/2887003003/diff/360001/chrome/browser/ui/view...
chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h:20: }
On 2017/06/21 20:47:33, sadrul wrote:
> This should go below in USE_AURA #ifdef (i.e. line ~27)

Done.

[sky, 2017-06-22 03:32:50]

Also please update 'BUG='. I think you have the wrong bug.

https://codereview.chromium.org/2887003003/diff/380001/chrome/browser/ui/view...
File chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc (right):

https://codereview.chromium.org/2887003003/diff/380001/chrome/browser/ui/view...
chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc:116: "Ash",
devtools_server_.get());
How is 'Ash' used? This code is run in non-ash code, so using Ash here seems
wrong.

[thanhph, 2017-06-22 16:19:50]

Description was changed from

==========
Create DomAgent and CSSAgent in Chrome. When DevTools is moved out of
ash to Chrome, this will enables using DevTools in Window and Linux
platform.

BUG=71143
==========

to

==========
Create DomAgent and CSSAgent in Chrome. When DevTools is moved out of
ash to Chrome, this will enables using DevTools in Window and Linux
platform.

BUG=711343
==========

[thanhph, 2017-06-22 16:43:00]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 16:43:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 18:09:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 18:09:09]

Dry run: This issue passed the CQ dry run.

[thanhph, 2017-06-22 18:11:12]

Thanks Scott. I updated the bug number. Please review my new patch.

Thanh.

https://codereview.chromium.org/2887003003/diff/380001/chrome/browser/ui/view...
File chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc (right):

https://codereview.chromium.org/2887003003/diff/380001/chrome/browser/ui/view...
chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc:116: "Ash",
devtools_server_.get());
On 2017/06/22 03:32:50, sky wrote:
> How is 'Ash' used? This code is run in non-ash code, so using Ash here seems
> wrong.

Thanks Scott. I changed to the string UiDevToolsClient which sounds more
reasonable.

[sky, 2017-06-22 20:24:33]

LGTM

[thanhph, 2017-06-22 20:26:45]

The CQ bit was checked by thanhph@chromium.org

[thanhph, 2017-06-22 20:26:45]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2887003003/#ps400001
(title: "address comments.")

[commit-bot: I haz the power, 2017-06-22 20:27:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 20:32:16]

CQ is committing da patch.

Bot data: {"patchset_id": 400001, "attempt_start_ts": 1498163205245950,
"parent_rev": "b83a4fa3ea202ca497cc9d82fcbb815b3e2ec512", "commit_rev":
"b3fb4aabd2307fdd7e15554f1d3b2413c6009d13"}

[commit-bot: I haz the power, 2017-06-22 20:32:37]

CQ is committing da patch.

Bot data: {"patchset_id": 400001, "attempt_start_ts": 1498163205245950,
"parent_rev": "1dbf942ec6c08f599611171101396e5b1d5d0eda", "commit_rev":
"a37a887a3612468ef05034aba0759e113d82e88a"}

[commit-bot: I haz the power, 2017-06-22 20:32:53]

Description was changed from

==========
Create DomAgent and CSSAgent in Chrome. When DevTools is moved out of
ash to Chrome, this will enables using DevTools in Window and Linux
platform.

BUG=711343
==========

to

==========
Create DomAgent and CSSAgent in Chrome. When DevTools is moved out of
ash to Chrome, this will enables using DevTools in Window and Linux
platform.

BUG=711343

Review-Url: https://codereview.chromium.org/2887003003
Cr-Commit-Position: refs/heads/master@{#481653}
Committed:
https://chromium.googlesource.com/chromium/src/+/a37a887a3612468ef05034aba075...
==========

[commit-bot: I haz the power, 2017-06-22 20:32:55]

Committed patchset #3 (id:400001) as
https://chromium.googlesource.com/chromium/src/+/a37a887a3612468ef05034aba075...