Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2886993002: Fix compile error in audio_manager_cras when dcheck_always_on=true (Closed)

Created:
3 years, 7 months ago by dmazzoni
Modified:
3 years, 7 months ago
Reviewers:
afakhry, justinlin
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix compile error in audio_manager_cras when dcheck_always_on=true This is speculative as I can't easily compile with use_cras=true without updating a full chrome os checkout first BUG=722827 TBR=justinlin NOTRY=true Review-Url: https://codereview.chromium.org/2886993002 Cr-Commit-Position: refs/heads/master@{#472227} Committed: https://chromium.googlesource.com/chromium/src/+/25ae5928489058ac5bf0d0e7230f8dc5873da175

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/audio/cras/audio_manager_cras.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
dmazzoni
3 years, 7 months ago (2017-05-16 21:43:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886993002/1
3 years, 7 months ago (2017-05-16 21:44:26 UTC) #6
afakhry
lgtm
3 years, 7 months ago (2017-05-16 21:51:19 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 22:15:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/25ae5928489058ac5bf0d0e7230f...

Powered by Google App Engine
This is Rietveld 408576698