Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2886973003:
ThemeSource: simplify thread hopping for NTP CSS (Closed)
|
Created:
3 years, 7 months ago by Marc Treib Modified:
3 years, 7 months ago Reviewers:
Dan Beam CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionThemeSource: simplify thread hopping for NTP CSS
ThemeSource used to cache the CSS for the NTP, which allowed it to serve
it directly on the IO thread without hopping back to UI. However,
https://codereview.chromium.org/2381093002 removed this cache, so the
hop is necessary again.
This CL slightly simplifies this by using the regular
URLDataSource::TaskRunnerForRequestPath facilities instead of manually
posting a task to the UI thread.
BUG=none
Review-Url: https://codereview.chromium.org/2886973003
Cr-Commit-Position: refs/heads/master@{#472734}
Committed: https://chromium.googlesource.com/chromium/src/+/2b0271854f085af5d04c60907258ccfa3d7984e2
Patch Set 1 #
Messages
Total messages: 21 (16 generated)
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
treib@chromium.org changed reviewers: + dbeam@chromium.org
PTAL! Should chrome/browser/themes/OWNERS also own the themes-related stuff in webui/?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/05/17 13:00:05, Marc Treib wrote: > PTAL! > > Should chrome/browser/themes/OWNERS also own the themes-related stuff in webui/? ¯\_(ツ)_/¯ up to them but i'm fine with it lgtm
On 2017/05/17 20:50:48, Dan Beam wrote: > On 2017/05/17 13:00:05, Marc Treib wrote: > > PTAL! > > > > Should chrome/browser/themes/OWNERS also own the themes-related stuff in > webui/? > > ¯\_(ツ)_/¯ up to them but i'm fine with it > > lgtm Eh, if you're fine with reviewing the occasional change here, then so am I :) Thanks!
The CQ bit was checked by treib@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495094121789940, "parent_rev":
"f195c43cff20208422063e0d9179b4a29415c28d", "commit_rev":
"2b0271854f085af5d04c60907258ccfa3d7984e2"}
Message was sent while issue was closed.
Description was changed from ========== ThemeSource: simplify thread hopping for NTP CSS ThemeSource used to cache the CSS for the NTP, which allowed it to serve it directly on the IO thread without hopping back to UI. However, https://codereview.chromium.org/2381093002 removed this cache, so the hop is necessary again. This CL slightly simplifies this by using the regular URLDataSource::TaskRunnerForRequestPath facilities instead of manually posting a task to the UI thread. BUG=none ========== to ========== ThemeSource: simplify thread hopping for NTP CSS ThemeSource used to cache the CSS for the NTP, which allowed it to serve it directly on the IO thread without hopping back to UI. However, https://codereview.chromium.org/2381093002 removed this cache, so the hop is necessary again. This CL slightly simplifies this by using the regular URLDataSource::TaskRunnerForRequestPath facilities instead of manually posting a task to the UI thread. BUG=none Review-Url: https://codereview.chromium.org/2886973003 Cr-Commit-Position: refs/heads/master@{#472734} Committed: https://chromium.googlesource.com/chromium/src/+/2b0271854f085af5d04c60907258... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2b0271854f085af5d04c60907258... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
