Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2886963004: Fixes for tree item level, setsize and posinset (Closed)

Created:
3 years, 7 months ago by aleventhal
Modified:
3 years, 7 months ago
Reviewers:
dmazzoni, aleventhal1
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, aboxhall, Peter Beverloo, nektar+watch_chromium.org, dmazzoni, jam, yuzo+watch_chromium.org, aboxhall+watch_chromium.org, nektarios, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews, je_julie, jochen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes for tree item level, setsize and posinset BUG=722530 Review-Url: https://codereview.chromium.org/2886963004 Cr-Commit-Position: refs/heads/master@{#473455} Committed: https://chromium.googlesource.com/chromium/src/+/f9ebe04352bf2dc7adc827b9932a5685e4aa8c60

Patch Set 1 : Add failing tests #

Patch Set 2 : Allow setsize and posinset when parent is presentational #

Patch Set 3 : Add missing treeitem roles to test #

Patch Set 4 : Rebase #

Patch Set 5 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -34 lines) Patch
M content/shell/test_runner/web_ax_object_proxy.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/test_runner/web_ax_object_proxy.cc View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-tree.html View 1 2 1 chunk +15 lines, -7 lines 0 comments Download
M content/test/data/accessibility/aria/aria-tree-expected-android.txt View 1 2 3 4 1 chunk +9 lines, -7 lines 0 comments Download
M content/test/data/accessibility/aria/aria-tree-expected-mac.txt View 1 2 3 4 1 chunk +11 lines, -9 lines 0 comments Download
M content/test/data/accessibility/aria/aria-tree-expected-win.txt View 1 2 3 4 1 chunk +11 lines, -9 lines 0 comments Download
A third_party/WebKit/LayoutTests/accessibility/aria-tree.html View 1 1 chunk +73 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 29 (24 generated)
aleventhal1
Ready for review
3 years, 7 months ago (2017-05-19 16:28:00 UTC) #22
aleventhal1
Ready for review
3 years, 7 months ago (2017-05-19 16:28:03 UTC) #23
dmazzoni
lgtm
3 years, 7 months ago (2017-05-19 19:05:08 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886963004/80001
3 years, 7 months ago (2017-05-20 22:48:44 UTC) #26
commit-bot: I haz the power
3 years, 7 months ago (2017-05-21 00:31:18 UTC) #29
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f9ebe04352bf2dc7adc827b9932a...

Powered by Google App Engine
This is Rietveld 408576698