[Android WebView] Propagate Java exceptions from JS dialog callbacks

[Android WebView] Propagate Java exceptions from JS dialog callbacks

WebView applications can throw run-time exceptions within
WebView-callbacks. When such an exception is thrown from either
onJsAlert, onJsConfirm, or onJsPrompt, it is not correctly propagated to
Android's feedback mechanism. This is because those callbacks are called
through JNI, and the default way of handling Java exceptions thrown on
the Java-side of JNI calls is to print the stack trace for the current
exception to the logcat when the JNI call returns to native, and then
intentionally crash in native.

With this CL we avoid the problem of propagating a Java exception back
through JNI and the native stack by posting the WebView-callback (which
can cause the Java exception) as a new task to the current Java Handler.
In that way any Java exception thrown inside the WebView-callback can be
propagated directly up to the Android framework's
UncaughtExceptionHandler which then properly reports the Exception
through the framework's crash reporting mechanism.

BUG=718921
Review-Url: https://codereview.chromium.org/2886963003
Cr-Commit-Position: refs/heads/master@{#472830}
Committed: https://chromium.googlesource.com/chromium/src/+/b5d138816ecd20145552720460906269c7f3a0fd

[gsennton, 2017-05-17 15:50:56]

gsennton@chromium.org changed reviewers:
+ torne@chromium.org

[gsennton, 2017-05-17 15:50:57]

ptal :)

[Torne, 2017-05-18 15:17:14]

lgtm

[gsennton, 2017-05-18 15:29:54]

The CQ bit was checked by gsennton@chromium.org

[commit-bot: I haz the power, 2017-05-18 15:30:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 16:06:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495121394404930, "parent_rev":
"125fe98091a0c74e39cb9920a32b49b3aaa0dfc3", "commit_rev":
"b5d138816ecd20145552720460906269c7f3a0fd"}

[commit-bot: I haz the power, 2017-05-18 16:06:43]

Description was changed from

==========
[Android WebView] Propagate Java exceptions from JS dialog callbacks

WebView applications can throw run-time exceptions within
WebView-callbacks. When such an exception is thrown from either
onJsAlert, onJsConfirm, or onJsPrompt, it is not correctly propagated to
Android's feedback mechanism. This is because those callbacks are called
through JNI, and the default way of handling Java exceptions thrown on
the Java-side of JNI calls is to print the stack trace for the current
exception to the logcat when the JNI call returns to native, and then
intentionally crash in native.

With this CL we avoid the problem of propagating a Java exception back
through JNI and the native stack by posting the WebView-callback (which
can cause the Java exception) as a new task to the current Java Handler.
In that way any Java exception thrown inside the WebView-callback can be
propagated directly up to the Android framework's
UncaughtExceptionHandler which then properly reports the Exception
through the framework's crash reporting mechanism.

BUG=718921
==========

to

==========
[Android WebView] Propagate Java exceptions from JS dialog callbacks

WebView applications can throw run-time exceptions within
WebView-callbacks. When such an exception is thrown from either
onJsAlert, onJsConfirm, or onJsPrompt, it is not correctly propagated to
Android's feedback mechanism. This is because those callbacks are called
through JNI, and the default way of handling Java exceptions thrown on
the Java-side of JNI calls is to print the stack trace for the current
exception to the logcat when the JNI call returns to native, and then
intentionally crash in native.

With this CL we avoid the problem of propagating a Java exception back
through JNI and the native stack by posting the WebView-callback (which
can cause the Java exception) as a new task to the current Java Handler.
In that way any Java exception thrown inside the WebView-callback can be
propagated directly up to the Android framework's
UncaughtExceptionHandler which then properly reports the Exception
through the framework's crash reporting mechanism.

BUG=718921

Review-Url: https://codereview.chromium.org/2886963003
Cr-Commit-Position: refs/heads/master@{#472830}
Committed:
https://chromium.googlesource.com/chromium/src/+/b5d138816ecd2014555272046090...
==========

[commit-bot: I haz the power, 2017-05-18 16:06:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b5d138816ecd2014555272046090...

[Avi (use Gerrit), 2017-05-18 17:46:18]

avi@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2017-05-18 17:46:19]

lgtm

This should be just fine. 👍