Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2886943006:
PDF Plugin: Add compile targets for a few files. (Closed)
DescriptionPDF Plugin: Add compile targets for a few files.
- gesture_detector
- open_pdf_params_parser
- pdf_scripting_api
- viewport_scroller
BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2886943006
Cr-Commit-Position: refs/heads/master@{#474025}
Committed: https://chromium.googlesource.com/chromium/src/+/d8ec752daeb8bd6815a87a6d41e40c8a98f257d4
Patch Set 1 : Move TODO #
Total comments: 4
Patch Set 2 : Address comments. #Patch Set 3 : Fix test error cause. #
Total comments: 1
Messages
Total messages: 31 (13 generated)
Description was changed from ========== PDF Plugin: Add compile target for gesture_detector. BUG=721073 ========== to ========== PDF Plugin: Add compile target for gesture_detector. BUG=721073 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== PDF Plugin: Add compile target for gesture_detector. BUG=721073 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== PDF Plugin: Add compile targets for a few files. - gesture_detector - open_pdf_params_parser - pdf_scripting_api - viewport_scroller BUG=721073 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
dpapad@chromium.org changed reviewers: + dbeam@chromium.org, dsinclair@chromium.org
@dbeam: Please review *compiled_resources2.gyp changes. @dsinclair: Please review chrome/browser/resources/pdf/ changes. Remaining files files, either: - involve cyclical dependencies (which I'll address in follow ups), or - involve missing chrome.tabs, chrome.metricsPrivate externs (started working on those already) I don't have a total number of errors remaining, since I am no longer compiling main js (not possible until circular deps are resolved).
On 2017/05/17 at 23:45:05, dpapad wrote: > @dbeam: Please review *compiled_resources2.gyp changes. > @dsinclair: Please review chrome/browser/resources/pdf/ changes. > > Remaining files files, either: > - involve cyclical dependencies (which I'll address in follow ups), or > - involve missing chrome.tabs, chrome.metricsPrivate externs (started working on those already) > > I don't have a total number of errors remaining, since I am no longer compiling main js (not possible until circular deps are resolved). Correction: s/chrome.metricsPrivate/chrome.mimeHandlerPrivate
mcnee@chromium.org changed reviewers: + mcnee@chromium.org
https://codereview.chromium.org/2886943006/diff/60001/chrome/browser/resource... File chrome/browser/resources/pdf/gesture_detector.js (right): https://codereview.chromium.org/2886943006/diff/60001/chrome/browser/resource... chrome/browser/resources/pdf/gesture_detector.js:25: var boundOnTouch = /** @type {function(!Event)} */ ( nit: We're using let throughout this file. https://codereview.chromium.org/2886943006/diff/60001/chrome/browser/resource... chrome/browser/resources/pdf/gesture_detector.js:106: var lastEvent = /** @type {!TouchEvent} */ (this.lastEvent_); nit: ditto
https://codereview.chromium.org/2886943006/diff/60001/chrome/browser/resource... File chrome/browser/resources/pdf/gesture_detector.js (right): https://codereview.chromium.org/2886943006/diff/60001/chrome/browser/resource... chrome/browser/resources/pdf/gesture_detector.js:25: var boundOnTouch = /** @type {function(!Event)} */ ( On 2017/05/18 at 14:41:52, Kevin McNee wrote: > nit: We're using let throughout this file. Done. https://codereview.chromium.org/2886943006/diff/60001/chrome/browser/resource... chrome/browser/resources/pdf/gesture_detector.js:106: var lastEvent = /** @type {!TouchEvent} */ (this.lastEvent_); On 2017/05/18 at 14:41:52, Kevin McNee wrote: > nit: ditto Done.
lgtm
On 2017/05/19 at 01:29:11, dbeam wrote: > lgtm @mcnee, dsinclair: Friendly ping.
non-owner lgtm
On 2017/05/19 at 19:54:30, mcnee wrote: > non-owner lgtm @dsinclair: Friendly ping
lgtm. Apologies, I don't work on Fridays so things can be a bit delayed if they get sent at the end of the week (and Monday was a holiday, heh).
The CQ bit was checked by dpapad@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2017/05/23 at 17:21:14, commit-bot wrote: > CQ is trying da patch. > > Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... FYI investigating the PDFExtensionTest.GestureDetector errors, they seem related to the files being affected.
On 2017/05/23 18:13:27, dpapad wrote: > On 2017/05/23 at 17:21:14, commit-bot wrote: > > CQ is trying da patch. > > > > Follow status at: > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... > > FYI investigating the PDFExtensionTest.GestureDetector errors, they seem related > to the files being affected. Initial thought: Since you've added |boundOnTouch| and are calling |addEventListener| with that each time rather than a separate |this.onTouch_.bind(this)|, the listeners are equal which is probably causing issues with the |listenerOptions| map in the test which is just keyed on the listener.
https://codereview.chromium.org/2886943006/diff/100001/chrome/browser/resourc... File chrome/browser/resources/pdf/gesture_detector.js (right): https://codereview.chromium.org/2886943006/diff/100001/chrome/browser/resourc... chrome/browser/resources/pdf/gesture_detector.js:22: /** @type {function(!Event)} */ (this.onTouchStart_.bind(this)), Changed the code to use a different function reference for each of the three listeners (as it was doing before), since the testPreventNativePinchZoom started failing. I don't understand why it is important to pass 3 different (but identical) functions to touchmove, touchend and touchcancel, it seems more of a test problem (state leaking across listeners), than a real issue in the prod code.
On 2017/05/23 at 18:36:08, mcnee wrote: > On 2017/05/23 18:13:27, dpapad wrote: > > On 2017/05/23 at 17:21:14, commit-bot wrote: > > > CQ is trying da patch. > > > > > > Follow status at: > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... > > > > FYI investigating the PDFExtensionTest.GestureDetector errors, they seem related > > to the files being affected. > > Initial thought: Since you've added |boundOnTouch| and are calling |addEventListener| with that each time rather than a separate |this.onTouch_.bind(this)|, the listeners are equal which is probably causing issues with the |listenerOptions| map in the test which is just keyed on the listener. Ah, I understand now. Thanks for the explanation.
The CQ bit was checked by dpapad@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dsinclair@chromium.org, mcnee@chromium.org, dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2886943006/#ps100001 (title: "Fix test error cause.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495564829483640,
"parent_rev": "969478f127f1aff63d6bc934b0b11ee2d4703c64", "commit_rev":
"d8ec752daeb8bd6815a87a6d41e40c8a98f257d4"}
Message was sent while issue was closed.
Description was changed from ========== PDF Plugin: Add compile targets for a few files. - gesture_detector - open_pdf_params_parser - pdf_scripting_api - viewport_scroller BUG=721073 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== PDF Plugin: Add compile targets for a few files. - gesture_detector - open_pdf_params_parser - pdf_scripting_api - viewport_scroller BUG=721073 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2886943006 Cr-Commit-Position: refs/heads/master@{#474025} Committed: https://chromium.googlesource.com/chromium/src/+/d8ec752daeb8bd6815a87a6d41e4... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:100001) as https://chromium.googlesource.com/chromium/src/+/d8ec752daeb8bd6815a87a6d41e4...
Message was sent while issue was closed.
On 2017/05/23 18:39:48, dpapad wrote: > On 2017/05/23 at 18:36:08, mcnee wrote: > > On 2017/05/23 18:13:27, dpapad wrote: > > > On 2017/05/23 at 17:21:14, commit-bot wrote: > > > > CQ is trying da patch. > > > > > > > > Follow status at: > > > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... > > > > > > FYI investigating the PDFExtensionTest.GestureDetector errors, they seem > related > > > to the files being affected. > > > > Initial thought: Since you've added |boundOnTouch| and are calling > |addEventListener| with that each time rather than a separate > |this.onTouch_.bind(this)|, the listeners are equal which is probably causing > issues with the |listenerOptions| map in the test which is just keyed on the > listener. > > Ah, I understand now. Thanks for the explanation. FYI: I've created a bug to address this: crbug.com/725630 Sorry about that. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
