Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1164)

Unified Diff: third_party/WebKit/Source/web/WebPageProblemDetector.h

Issue 2886943003: [Offline Pages] Adding missing image/CSS detection in FrameSerializer. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebPageProblemDetector.h
diff --git a/third_party/WebKit/Source/web/WebPageProblemDetector.h b/third_party/WebKit/Source/web/WebPageProblemDetector.h
new file mode 100644
index 0000000000000000000000000000000000000000..8ae7a558821ec55ca034089debd1106854b4142c
--- /dev/null
+++ b/third_party/WebKit/Source/web/WebPageProblemDetector.h
@@ -0,0 +1,94 @@
+/*
+ * Copyright (C) 2017 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef WebPageProblemDetector_h
+#define WebPageProblemDetector_h
+
+#include <memory>
+#include <vector>
+
+namespace blink {
+
+class Node;
+
+// Interface for individual web page problem detector, which will be called
+// through MHTMLFrameSerializerDelegate on each of the node during DOM walking
+// when serializing a page as MHTML.
+class WebPageProblemDetector {
+ public:
+ // Visits a node in the DOM tree.
+ virtual void VisitNode(const Node*) = 0;
+ // Called when the visiting finishes.
+ virtual void VisitingDone() = 0;
+};
+
+// Holds all problem detectors so we can visit all of them.
+class WebPageProblemDetectorCollection : public WebPageProblemDetector {
+ public:
+ // Used to register a problem detector.
+ void AddDetector(std::unique_ptr<WebPageProblemDetector>);
+
+ // When we are visiting a node, call all registered problem observers and give
+ // them an opportunity to examine the node.
+ void VisitNode(const Node*) override;
+
+ // When the DOM walk is over, give each detector a chance to compute and
+ // report results.
+ void VisitingDone() override;
+
+ private:
+ std::vector<std::unique_ptr<WebPageProblemDetector>> detectors_;
+};
+
+// A class which tries to gather information to determine if a page can be
+// treated as a blank page during page serialization as MHTML.
+class BlankPageDetector : public WebPageProblemDetector {
+ void VisitNode(const Node*) override;
+ void VisitingDone() override;
+};
+
+// A class which tries to gather information about number of missing images of a
+// page during page serialization as MHTML.
+class MissingImageDetector : public WebPageProblemDetector {
Pete Williamson 2017/05/17 00:31:48 Let's move this and the CSS detector into their ow
romax 2017/05/17 22:28:19 Done.
+ public:
+ void VisitNode(const Node*) override;
+ void VisitingDone() override;
+};
+
+// A class which tries to gather information about if the page is missing CSS
+// files during page serialization as MHTML.
+class MissingCSSDetector : public WebPageProblemDetector {
+ public:
+ void VisitNode(const Node*) override;
+ void VisitingDone() override;
+};
+
+} // namespace blink
+#endif // WebPageProblemDetector_h

Powered by Google App Engine
This is Rietveld 408576698