Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1430)

Unified Diff: third_party/WebKit/Source/web/WebPageProblemDetector.cpp

Issue 2886943003: [Offline Pages] Adding missing image/CSS detection in FrameSerializer. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebPageProblemDetector.cpp
diff --git a/third_party/WebKit/Source/web/WebPageProblemDetector.cpp b/third_party/WebKit/Source/web/WebPageProblemDetector.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..e4f15d4e5d6a4835e003a2c16f886014c23a5820
--- /dev/null
+++ b/third_party/WebKit/Source/web/WebPageProblemDetector.cpp
@@ -0,0 +1,64 @@
+/*
+ * Copyright (C) 2017 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "web/WebPageProblemDetector.h"
+
+#include "core/dom/Node.h"
+
+namespace blink {
+
+void WebPageProblemDetectorCollection::AddDetector(
+ std::unique_ptr<WebPageProblemDetector> detector) {
+ detectors_.emplace_back(std::move(detector));
+}
+
+void WebPageProblemDetectorCollection::VisitNode(const Node* node) {
+ for (const auto& detector : detectors_)
+ detector->VisitNode(node);
+}
+
+void WebPageProblemDetectorCollection::VisitingDone() {
+ for (const auto& detector : detectors_)
+ detector->VisitingDone();
+}
+
+void BlankPageDetector::VisitNode(const Node* node) {}
+
+void BlankPageDetector::VisitingDone() {}
+
+void MissingImageDetector::VisitNode(const Node* node) {}
Pete Williamson 2017/05/17 00:31:48 Let's move these into their own cpp files.
romax 2017/05/17 22:28:19 Done.
+
+void MissingImageDetector::VisitingDone() {}
+
+void MissingCSSDetector::VisitNode(const Node* node) {}
+
+void MissingCSSDetector::VisitingDone() {}
+
+} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698