ios/chrome/browser/ui/browser_view_controller.mm - Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)

Patch Set: simplify type checking Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/browser_view_controller.mm

diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm

index 095f61960198cd62431238e19f41975160ca4bbc..7f32a91cd5f917765ce67e885eeaad3cf2fdeaf1 100644

--- a/ios/chrome/browser/ui/browser_view_controller.mm

+++ b/ios/chrome/browser/ui/browser_view_controller.mm

@@ -237,7 +237,7 @@ typedef NS_ENUM(NSInteger, ContextMenuHistogram) {

NUM_ACTIONS = 23,

};

-void Record(NSInteger action, bool is_image, bool is_link) {

+void Record(ContextMenuHistogram action, bool is_image, bool is_link) {

if (is_image) {

if (is_link) {

UMA_HISTOGRAM_ENUMERATION("ContextMenu.SelectedOption.ImageLink", action,