Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)
Patch Set: simplify type checking Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/ui/browser_view_controller.h" 5 #import "ios/chrome/browser/ui/browser_view_controller.h"
6 6
7 #import <AssetsLibrary/AssetsLibrary.h> 7 #import <AssetsLibrary/AssetsLibrary.h>
8 #import <MobileCoreServices/MobileCoreServices.h> 8 #import <MobileCoreServices/MobileCoreServices.h>
9 #import <PassKit/PassKit.h> 9 #import <PassKit/PassKit.h>
10 #import <Photos/Photos.h> 10 #import <Photos/Photos.h>
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 ACTION_COPY_LINK_ADDRESS = 2, 230 ACTION_COPY_LINK_ADDRESS = 2,
231 ACTION_SAVE_IMAGE = 6, 231 ACTION_SAVE_IMAGE = 6,
232 ACTION_OPEN_IMAGE = 7, 232 ACTION_OPEN_IMAGE = 7,
233 ACTION_OPEN_IMAGE_IN_NEW_TAB = 8, 233 ACTION_OPEN_IMAGE_IN_NEW_TAB = 8,
234 ACTION_SEARCH_BY_IMAGE = 11, 234 ACTION_SEARCH_BY_IMAGE = 11,
235 ACTION_OPEN_JAVASCRIPT = 21, 235 ACTION_OPEN_JAVASCRIPT = 21,
236 ACTION_READ_LATER = 22, 236 ACTION_READ_LATER = 22,
237 NUM_ACTIONS = 23, 237 NUM_ACTIONS = 23,
238 }; 238 };
239 239
240 void Record(NSInteger action, bool is_image, bool is_link) { 240 void Record(ContextMenuHistogram action, bool is_image, bool is_link) {
241 if (is_image) { 241 if (is_image) {
242 if (is_link) { 242 if (is_link) {
243 UMA_HISTOGRAM_ENUMERATION("ContextMenu.SelectedOption.ImageLink", action, 243 UMA_HISTOGRAM_ENUMERATION("ContextMenu.SelectedOption.ImageLink", action,
244 NUM_ACTIONS); 244 NUM_ACTIONS);
245 } else { 245 } else {
246 UMA_HISTOGRAM_ENUMERATION("ContextMenu.SelectedOption.Image", action, 246 UMA_HISTOGRAM_ENUMERATION("ContextMenu.SelectedOption.Image", action,
247 NUM_ACTIONS); 247 NUM_ACTIONS);
248 } 248 }
249 } else { 249 } else {
250 UMA_HISTOGRAM_ENUMERATION("ContextMenu.SelectedOption.Link", action, 250 UMA_HISTOGRAM_ENUMERATION("ContextMenu.SelectedOption.Link", action,
(...skipping 4998 matching lines...) Expand 10 before | Expand all | Expand 10 after
5249 5249
5250 - (UIView*)voiceSearchButton { 5250 - (UIView*)voiceSearchButton {
5251 return _voiceSearchButton; 5251 return _voiceSearchButton;
5252 } 5252 }
5253 5253
5254 - (id<LogoAnimationControllerOwner>)logoAnimationControllerOwner { 5254 - (id<LogoAnimationControllerOwner>)logoAnimationControllerOwner {
5255 return [self currentLogoAnimationControllerOwner]; 5255 return [self currentLogoAnimationControllerOwner];
5256 } 5256 }
5257 5257
5258 @end 5258 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698