chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc - Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)

Patch Set: nocompile test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/message_center_stats_collector.cc ('k') | chrome/browser/policy/cloud/cloud_policy_invalidator.h » ('j') | components/sync/driver/frontend_data_type_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

index 9ff167c6e25c5c44f713b248f8b0b71a630782c7..87c994caed279e5e7c547556824e7576e830fc7e 100644

--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

@@ -718,9 +718,9 @@ void CorePageLoadMetricsObserver::RecordTimingHistograms(

(first_user_interaction_after_first_paint_.is_null() ? 0

: HAD_USER_INPUT) +

(timing.paint_timing->first_meaningful_paint ? NETWORK_STABLE : 0);

- UMA_HISTOGRAM_ENUMERATION(

- internal::kHistogramFirstMeaningfulPaintSignalStatus2,

- signal_status, FIRST_MEANINGFUL_PAINT_SIGNAL_STATUS_LAST_ENTRY);

+ UMA_HISTOGRAM_EXACT_LINEAR(

+ internal::kHistogramFirstMeaningfulPaintSignalStatus2, signal_status,

+ static_cast<int>(FIRST_MEANINGFUL_PAINT_SIGNAL_STATUS_LAST_ENTRY));

}

if (timing.paint_timing->first_meaningful_paint) {

if (first_user_interaction_after_first_paint_.is_null()) {