Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: base/android/library_loader/library_loader_hooks.cc

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)
Patch Set: nocompile test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/library_loader/library_loader_hooks.cc
diff --git a/base/android/library_loader/library_loader_hooks.cc b/base/android/library_loader/library_loader_hooks.cc
index 621575c3f71d6fb9942a8ab7286df1e54942856f..81955e5ee7922041e69275eb78723534d16c929f 100644
--- a/base/android/library_loader/library_loader_hooks.cc
+++ b/base/android/library_loader/library_loader_hooks.cc
@@ -124,9 +124,10 @@ static void RecordChromiumAndroidLinkerBrowserHistogram(
MAX_BROWSER_HISTOGRAM_CODE);
// Record the device support for loading a library directly from the APK file.
- UMA_HISTOGRAM_ENUMERATION("ChromiumAndroidLinker.LibraryLoadFromApkStatus",
- library_load_from_apk_status,
- LIBRARY_LOAD_FROM_APK_STATUS_CODES_MAX);
+ UMA_HISTOGRAM_ENUMERATION(
+ "ChromiumAndroidLinker.LibraryLoadFromApkStatus",
+ static_cast<LibraryLoadFromApkStatusCodes>(library_load_from_apk_status),
+ LIBRARY_LOAD_FROM_APK_STATUS_CODES_MAX);
// Record how long it took to load the shared libraries.
UMA_HISTOGRAM_TIMES("ChromiumAndroidLinker.BrowserLoadTime",

Powered by Google App Engine
This is Rietveld 408576698