Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)
Patch Set: nocompile test Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/ui/browser_view_controller.h" 5 #import "ios/chrome/browser/ui/browser_view_controller.h"
6 6
7 #import <AssetsLibrary/AssetsLibrary.h> 7 #import <AssetsLibrary/AssetsLibrary.h>
8 #import <MobileCoreServices/MobileCoreServices.h> 8 #import <MobileCoreServices/MobileCoreServices.h>
9 #import <PassKit/PassKit.h> 9 #import <PassKit/PassKit.h>
10 #import <Photos/Photos.h> 10 #import <Photos/Photos.h>
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 ACTION_COPY_LINK_ADDRESS = 2, 226 ACTION_COPY_LINK_ADDRESS = 2,
227 ACTION_SAVE_IMAGE = 6, 227 ACTION_SAVE_IMAGE = 6,
228 ACTION_OPEN_IMAGE = 7, 228 ACTION_OPEN_IMAGE = 7,
229 ACTION_OPEN_IMAGE_IN_NEW_TAB = 8, 229 ACTION_OPEN_IMAGE_IN_NEW_TAB = 8,
230 ACTION_SEARCH_BY_IMAGE = 11, 230 ACTION_SEARCH_BY_IMAGE = 11,
231 ACTION_OPEN_JAVASCRIPT = 21, 231 ACTION_OPEN_JAVASCRIPT = 21,
232 ACTION_READ_LATER = 22, 232 ACTION_READ_LATER = 22,
233 NUM_ACTIONS = 23, 233 NUM_ACTIONS = 23,
234 }; 234 };
235 235
236 void Record(NSInteger action, bool is_image, bool is_link) { 236 void Record(ContextMenuHistogram action, bool is_image, bool is_link) {
237 if (is_image) { 237 if (is_image) {
238 if (is_link) { 238 if (is_link) {
239 UMA_HISTOGRAM_ENUMERATION("ContextMenu.SelectedOption.ImageLink", action, 239 UMA_HISTOGRAM_ENUMERATION("ContextMenu.SelectedOption.ImageLink", action,
240 NUM_ACTIONS); 240 NUM_ACTIONS);
241 } else { 241 } else {
242 UMA_HISTOGRAM_ENUMERATION("ContextMenu.SelectedOption.Image", action, 242 UMA_HISTOGRAM_ENUMERATION("ContextMenu.SelectedOption.Image", action,
243 NUM_ACTIONS); 243 NUM_ACTIONS);
244 } 244 }
245 } else { 245 } else {
246 UMA_HISTOGRAM_ENUMERATION("ContextMenu.SelectedOption.Link", action, 246 UMA_HISTOGRAM_ENUMERATION("ContextMenu.SelectedOption.Link", action,
(...skipping 4934 matching lines...) Expand 10 before | Expand all | Expand 10 after
5181 5181
5182 - (UIView*)voiceSearchButton { 5182 - (UIView*)voiceSearchButton {
5183 return _voiceSearchButton; 5183 return _voiceSearchButton;
5184 } 5184 }
5185 5185
5186 - (id<LogoAnimationControllerOwner>)logoAnimationControllerOwner { 5186 - (id<LogoAnimationControllerOwner>)logoAnimationControllerOwner {
5187 return [self currentLogoAnimationControllerOwner]; 5187 return [self currentLogoAnimationControllerOwner];
5188 } 5188 }
5189 5189
5190 @end 5190 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698