Make EnabledInEditableText return false for user-triggered command and unfocused selection

Make EnabledInEditableText return false for user-triggered command and unfocused selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledInEditableText to fix
the behavior of these commands:

BackwardDelete
DeleteBackward
DeleteBackwardByDecomposingPreviousCharacter
DeleteForward
DeleteToBeginningOfLine
DeleteToBeginningOfParagraph
DeleteToEndOfLine
DeleteToEndOfParagraph
DeleteToMark
DeleteWordBackward
DeleteWordForward
ForwardDelete
IgnoreSpelling
InsertBacktab
InsertHTML
InsertLineBreak
InsertNewline
InsertParagraph
InsertTab
InsertText
MoveBackward
MoveDown
MoveForward
MoveLeft
MovePageDown
MovePageUp
MoveParagraphBackward
MoveParagraphForward
MoveRight
MoveToBeginningOfDocument
MoveToBeginningOfLine
MoveToBeginningOfParagraph
MoveToBeginningOfSentence
MoveToEndOfDocument
MoveToEndOfLine
MoveToEndOfParagraph
MoveToEndOfSentence
MoveToLeftEndOfLine
MoveToLeftEndOfLineAndModifySelection
MoveToRightEndOfLine
MoveToRightEndOfLineAndModifySelection
MoveUp
MoveWordBackward
MoveWordForward
MoveWordLeft
MoveWordRight
Yank
YankAndSelect

BUG=713607, 722925
TEST=editing/selection/arrow_key_with_unfocused_selection.html

Review-Url: https://codereview.chromium.org/2886933002
Cr-Commit-Position: refs/heads/master@{#472284}
Committed: https://chromium.googlesource.com/chromium/src/+/2e91966df2e6a57cafb584bfa72e19bc2e9bb620

[Xiaocheng, 2017-05-16 19:32:19]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 19:35:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-16 20:58:59]

Description was changed from

==========
Make EnabledInEditableText return false for user-triggered command and unfocused
selection

BUG=713607, 722925
==========

to

==========
Make EnabledInEditableText return false for user-triggered command and unfocused
selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledInEditableText to fix
the behavior of these commands:

BackwardDelete
DeleteBackward
DeleteBackwardByDecomposingPreviousCharacter
DeleteForward
DeleteToBeginningOfLine
DeleteToBeginningOfParagraph
DeleteToEndOfLine
DeleteToEndOfParagraph
DeleteToMark
DeleteWordBackward
DeleteWordForward
ForwardDelete
IgnoreSpelling
InsertBacktab
InsertHTML
InsertLineBreak
InsertNewline
InsertParagraph
InsertTab
InsertText
MoveBackward
MoveDown
MoveForward
MoveLeft
MovePageDown
MovePageUp
MoveParagraphBackward
MoveParagraphForward
MoveRight
MoveToBeginningOfDocument
MoveToBeginningOfLine
MoveToBeginningOfParagraph
MoveToBeginningOfSentence
MoveToEndOfDocument
MoveToEndOfLine
MoveToEndOfParagraph
MoveToEndOfSentence
MoveToLeftEndOfLine
MoveToLeftEndOfLineAndModifySelection
MoveToRightEndOfLine
MoveToRightEndOfLineAndModifySelection
MoveUp
MoveWordBackward
MoveWordForward
MoveWordLeft
MoveWordRight
Yank
YankAndSelect

BUG=713607, 722925
==========

[Xiaocheng, 2017-05-16 20:59:12]

Description was changed from

==========
Make EnabledInEditableText return false for user-triggered command and unfocused
selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledInEditableText to fix
the behavior of these commands:

BackwardDelete
DeleteBackward
DeleteBackwardByDecomposingPreviousCharacter
DeleteForward
DeleteToBeginningOfLine
DeleteToBeginningOfParagraph
DeleteToEndOfLine
DeleteToEndOfParagraph
DeleteToMark
DeleteWordBackward
DeleteWordForward
ForwardDelete
IgnoreSpelling
InsertBacktab
InsertHTML
InsertLineBreak
InsertNewline
InsertParagraph
InsertTab
InsertText
MoveBackward
MoveDown
MoveForward
MoveLeft
MovePageDown
MovePageUp
MoveParagraphBackward
MoveParagraphForward
MoveRight
MoveToBeginningOfDocument
MoveToBeginningOfLine
MoveToBeginningOfParagraph
MoveToBeginningOfSentence
MoveToEndOfDocument
MoveToEndOfLine
MoveToEndOfParagraph
MoveToEndOfSentence
MoveToLeftEndOfLine
MoveToLeftEndOfLineAndModifySelection
MoveToRightEndOfLine
MoveToRightEndOfLineAndModifySelection
MoveUp
MoveWordBackward
MoveWordForward
MoveWordLeft
MoveWordRight
Yank
YankAndSelect

BUG=713607, 722925
==========

to

==========
Make EnabledInEditableText return false for user-triggered command and unfocused
selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledInEditableText to fix
the behavior of these commands:

BackwardDelete
DeleteBackward
DeleteBackwardByDecomposingPreviousCharacter
DeleteForward
DeleteToBeginningOfLine
DeleteToBeginningOfParagraph
DeleteToEndOfLine
DeleteToEndOfParagraph
DeleteToMark
DeleteWordBackward
DeleteWordForward
ForwardDelete
IgnoreSpelling
InsertBacktab
InsertHTML
InsertLineBreak
InsertNewline
InsertParagraph
InsertTab
InsertText
MoveBackward
MoveDown
MoveForward
MoveLeft
MovePageDown
MovePageUp
MoveParagraphBackward
MoveParagraphForward
MoveRight
MoveToBeginningOfDocument
MoveToBeginningOfLine
MoveToBeginningOfParagraph
MoveToBeginningOfSentence
MoveToEndOfDocument
MoveToEndOfLine
MoveToEndOfParagraph
MoveToEndOfSentence
MoveToLeftEndOfLine
MoveToLeftEndOfLineAndModifySelection
MoveToRightEndOfLine
MoveToRightEndOfLineAndModifySelection
MoveUp
MoveWordBackward
MoveWordForward
MoveWordLeft
MoveWordRight
Yank
YankAndSelect

BUG=713607, 722925
TEST=editing/selection/arrow_key_with_unfocused_selection.html
==========

[Xiaocheng, 2017-05-16 20:59:33]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-05-16 20:59:33]

PTAL.

[commit-bot: I haz the power, 2017-05-16 22:19:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 22:19:45]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-05-17 01:57:12]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-05-17 01:57:13]

lgtm

[commit-bot: I haz the power, 2017-05-17 01:58:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 02:06:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494986232800510, "parent_rev":
"be58808056df4a76ea7ae3b6831bb8f24e2ad7fc", "commit_rev":
"2e91966df2e6a57cafb584bfa72e19bc2e9bb620"}

[commit-bot: I haz the power, 2017-05-17 02:06:28]

Description was changed from

==========
Make EnabledInEditableText return false for user-triggered command and unfocused
selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledInEditableText to fix
the behavior of these commands:

BackwardDelete
DeleteBackward
DeleteBackwardByDecomposingPreviousCharacter
DeleteForward
DeleteToBeginningOfLine
DeleteToBeginningOfParagraph
DeleteToEndOfLine
DeleteToEndOfParagraph
DeleteToMark
DeleteWordBackward
DeleteWordForward
ForwardDelete
IgnoreSpelling
InsertBacktab
InsertHTML
InsertLineBreak
InsertNewline
InsertParagraph
InsertTab
InsertText
MoveBackward
MoveDown
MoveForward
MoveLeft
MovePageDown
MovePageUp
MoveParagraphBackward
MoveParagraphForward
MoveRight
MoveToBeginningOfDocument
MoveToBeginningOfLine
MoveToBeginningOfParagraph
MoveToBeginningOfSentence
MoveToEndOfDocument
MoveToEndOfLine
MoveToEndOfParagraph
MoveToEndOfSentence
MoveToLeftEndOfLine
MoveToLeftEndOfLineAndModifySelection
MoveToRightEndOfLine
MoveToRightEndOfLineAndModifySelection
MoveUp
MoveWordBackward
MoveWordForward
MoveWordLeft
MoveWordRight
Yank
YankAndSelect

BUG=713607, 722925
TEST=editing/selection/arrow_key_with_unfocused_selection.html
==========

to

==========
Make EnabledInEditableText return false for user-triggered command and unfocused
selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledInEditableText to fix
the behavior of these commands:

BackwardDelete
DeleteBackward
DeleteBackwardByDecomposingPreviousCharacter
DeleteForward
DeleteToBeginningOfLine
DeleteToBeginningOfParagraph
DeleteToEndOfLine
DeleteToEndOfParagraph
DeleteToMark
DeleteWordBackward
DeleteWordForward
ForwardDelete
IgnoreSpelling
InsertBacktab
InsertHTML
InsertLineBreak
InsertNewline
InsertParagraph
InsertTab
InsertText
MoveBackward
MoveDown
MoveForward
MoveLeft
MovePageDown
MovePageUp
MoveParagraphBackward
MoveParagraphForward
MoveRight
MoveToBeginningOfDocument
MoveToBeginningOfLine
MoveToBeginningOfParagraph
MoveToBeginningOfSentence
MoveToEndOfDocument
MoveToEndOfLine
MoveToEndOfParagraph
MoveToEndOfSentence
MoveToLeftEndOfLine
MoveToLeftEndOfLineAndModifySelection
MoveToRightEndOfLine
MoveToRightEndOfLineAndModifySelection
MoveUp
MoveWordBackward
MoveWordForward
MoveWordLeft
MoveWordRight
Yank
YankAndSelect

BUG=713607, 722925
TEST=editing/selection/arrow_key_with_unfocused_selection.html

Review-Url: https://codereview.chromium.org/2886933002
Cr-Commit-Position: refs/heads/master@{#472284}
Committed:
https://chromium.googlesource.com/chromium/src/+/2e91966df2e6a57cafb584bfa72e...
==========

[commit-bot: I haz the power, 2017-05-17 02:06:29]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2e91966df2e6a57cafb584bfa72e...