Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2886913004: Copy some x509_certificate_model_nss functions to src/chromeos (reland) (Closed)

Created:
3 years, 7 months ago by stevenjb
Modified:
3 years, 7 months ago
Reviewers:
afakhry
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Copy some x509_certificate_model_nss functions to src/chromeos (reland) Currently the Chrome OS network configuration UI is in src/chrome. We want to move this to Settings UI which uses the networkingPrivate extension API which is implemented in src/chromeos. For network configuration we need to provide a list of available certificates, including their display names, so we will need to duplicate much of the logic in CertLibrary. This is some initial cleanup work which removes the CertLibrary dependency on chrome/common/net/x509_certificate_model_nss.cc (which in turn depends on chrome/third_party/mozilla_security_manager and contains significantly more code than CertLibrary needs and would be difficult to migrate out of src/chrome). It also removes some unnecessary src/chrome dependencies, and modifies onc_certificate_importer_impl_unittest.cc to use the new helper method instead of its own copied version of GetCertType. BUG=380937 R=afakhry@chromium.org TBR=emaxx@chromium.org, mattm@chromium.org, pmarko@chromium.org, tbarzic@chromium.org Original CL: https://codereview.chromium.org/2871993005 Review-Url: https://codereview.chromium.org/2886913004 . Cr-Commit-Position: refs/heads/master@{#472930} Committed: https://chromium.googlesource.com/chromium/src/+/538486fe49422db484d6d5af74295a9f3e048442

Patch Set 1 #

Patch Set 2 : Add CHROMEOS_EXPORT #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -55 lines) Patch
M chrome/browser/chromeos/options/cert_library.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/options/cert_library.cc View 5 chunks +18 lines, -16 lines 0 comments Download
M chromeos/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A chromeos/network/certificate_helper.h View 1 1 chunk +50 lines, -0 lines 0 comments Download
A chromeos/network/certificate_helper.cc View 1 chunk +93 lines, -0 lines 0 comments Download
A chromeos/network/certificate_helper_unittest.cc View 1 chunk +89 lines, -0 lines 0 comments Download
M chromeos/network/onc/onc_certificate_importer_impl_unittest.cc View 4 chunks +5 lines, -39 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
stevenjb
3 years, 7 months ago (2017-05-17 18:20:53 UTC) #3
afakhry
lgtm
3 years, 7 months ago (2017-05-17 18:30:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886913004/20001
3 years, 7 months ago (2017-05-17 18:33:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/429474)
3 years, 7 months ago (2017-05-17 21:07:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886913004/20001
3 years, 7 months ago (2017-05-17 21:30:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/429953)
3 years, 7 months ago (2017-05-18 03:05:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886913004/20001
3 years, 7 months ago (2017-05-18 15:49:04 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/448761)
3 years, 7 months ago (2017-05-18 19:39:49 UTC) #16
stevenjb
3 years, 7 months ago (2017-05-18 21:02:23 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
538486fe49422db484d6d5af74295a9f3e048442 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698