Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2886903006: DevTools: do not hide run audit dialog upon canceling the audit, allow it being re-run. (Closed)

Created:
3 years, 7 months ago by pfeldman
Modified:
3 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: do not hide run audit dialog upon canceling the audit, allow it being re-run. BUG=723399 Review-Url: https://codereview.chromium.org/2886903006 Cr-Commit-Position: refs/heads/master@{#473278} Committed: https://chromium.googlesource.com/chromium/src/+/93262850d71a2091db3295a8fb88cbcce5af14cc

Patch Set 1 #

Patch Set 2 : same #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js View 1 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
pfeldman
3 years, 7 months ago (2017-05-18 21:29:42 UTC) #2
dgozman
lgtm
3 years, 7 months ago (2017-05-18 21:30:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886903006/20001
3 years, 7 months ago (2017-05-18 23:28:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/388279)
3 years, 7 months ago (2017-05-19 00:27:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886903006/20001
3 years, 7 months ago (2017-05-19 18:12:07 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 19:36:34 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/93262850d71a2091db3295a8fb88...

Powered by Google App Engine
This is Rietveld 408576698