Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2886903005: Linux native notifications: Require 'actions' and 'body' capabilities (Closed)

Created:
3 years, 7 months ago by Tom Anderson
Modified:
3 years, 7 months ago
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux native notifications: Require 'actions' and 'body' capabilities Actions and body text are necessary and expected to be available for web notifications, so blacklist servers that don't support them. The conditions for using native notifications are described at the end of [1] (Google-only). [1] https://docs.google.com/a/google.com/document/d/1cqXPpIyCf1RaEYx9XCPjZbO6U5oDeyslajznnG9wd_U/edit?usp=sharing BUG=676220 R=peter@chromium.org,thestig@chromium.org Review-Url: https://codereview.chromium.org/2886903005 Cr-Commit-Position: refs/heads/master@{#472959} Committed: https://chromium.googlesource.com/chromium/src/+/49db099a77be5b377b63e41373840a2b8413e6ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -21 lines) Patch
M chrome/browser/notifications/notification_platform_bridge_linux.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc View 4 chunks +58 lines, -21 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
Tom Anderson
3 years, 7 months ago (2017-05-18 18:04:39 UTC) #1
Lei Zhang
lgtm
3 years, 7 months ago (2017-05-18 18:21:13 UTC) #2
Peter Beverloo
lgtm
3 years, 7 months ago (2017-05-18 20:08:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886903005/1
3 years, 7 months ago (2017-05-18 22:40:44 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 22:49:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/49db099a77be5b377b63e4137384...

Powered by Google App Engine
This is Rietveld 408576698