Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 2886903004: Revert of [recipe_modules/step] do not set cwd if it is start_dir. (Closed)

Created:
3 years, 7 months ago by nodir
Modified:
3 years, 7 months ago
Reviewers:
dnj, iannucci
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of [recipe_modules/step] do not set cwd if it is start_dir. (patchset #3 id:10009 of https://codereview.chromium.org/2875543002/ ) Reason for revert: see comment 20 Original issue's description: > [recipe_modules/step] do not set cwd if it is start_dir. > > This makes expectations consistent (i.e. steps that are run without cwd > and steps run in start_dir have the same representation in expectations, > because they have the same behavior). > > R=dnj@chromium.org > BUG= > > Review-Url: https://codereview.chromium.org/2875543002 > Committed: https://github.com/luci/recipes-py/commit/c93ed98c3c3e6c9be82e88496e55cb1f3dd13372 TBR=dnj@chromium.org,iannucci@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -160 lines) Patch
M recipe_modules/step/api.py View 2 chunks +3 lines, -3 lines 0 comments Download
M recipe_modules/step/example.py View 4 chunks +5 lines, -13 lines 0 comments Download
M recipe_modules/step/example.expected/basic.json View 1 chunk +0 lines, -24 lines 0 comments Download
M recipe_modules/step/example.expected/defer_results.json View 1 chunk +0 lines, -24 lines 0 comments Download
M recipe_modules/step/example.expected/exceptional.json View 1 chunk +0 lines, -24 lines 0 comments Download
M recipe_modules/step/example.expected/infra_failure.json View 1 chunk +0 lines, -24 lines 0 comments Download
M recipe_modules/step/example.expected/invalid_access.json View 1 chunk +0 lines, -24 lines 0 comments Download
M recipe_modules/step/example.expected/warning.json View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
nodir
Created Revert of [recipe_modules/step] do not set cwd if it is start_dir.
3 years, 7 months ago (2017-05-17 17:38:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886903004/1
3 years, 7 months ago (2017-05-17 17:38:43 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Recipes-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/36304f3f91454710)
3 years, 7 months ago (2017-05-17 17:41:53 UTC) #5
iannucci
This one is going to be hard to revert
3 years, 7 months ago (2017-05-17 17:47:09 UTC) #6
jbudorick
On 2017/05/17 17:47:09, iannucci wrote: > This one is going to be hard to revert ...
3 years, 7 months ago (2017-05-17 17:59:45 UTC) #7
iannucci
Something in the recipe looks like it's deleting the current working directory of the engine. ...
3 years, 7 months ago (2017-05-17 18:03:13 UTC) #8
iannucci
3 years, 7 months ago (2017-05-17 18:26:08 UTC) #9
https://codereview.chromium.org/2885293003 should have the same effect, but
should give us more debugging info too.

Powered by Google App Engine
This is Rietveld 408576698