Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(32)

Issue 2886883003: Remove content::kFontListSequenceToken. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by fdoray
Modified:
1 month, 1 week ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove content::kFontListSequenceToken. SequencedWorkerPool and named sequence tokens are being deprecated in favor of TaskScheduler. BUG=667892 Review-Url: https://codereview.chromium.org/2886883003 Cr-Commit-Position: refs/heads/master@{#472794} Committed: https://chromium.googlesource.com/chromium/src/+/26f887dbd762f7f1b802cb70dd4de5f48a243029

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -65 lines) Patch
M content/browser/font_list_async.cc View 1 chunk +5 lines, -31 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_browser_font_singleton_host.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_truetype_font_list_host.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M content/common/font_list.h View 1 chunk +10 lines, -12 lines 0 comments Download
M content/common/font_list.cc View 1 chunk +21 lines, -1 line 0 comments Download
M content/common/font_list_fontconfig.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/browser/font_list_async.h View 2 chunks +4 lines, -5 lines 0 comments Download
Trybot results:  win_chromium_x64_rel_ng   linux_chromium_chromeos_ozone_rel_ng   win_clang   win_chromium_rel_ng   win_chromium_x64_rel_ng   mac_chromium_rel_ng   win_chromium_compile_dbg_ng   mac_chromium_compile_dbg_ng   ios-simulator-xcode-clang   ios-simulator   ios-device-xcode-clang   ios-device   linux_chromium_tsan_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_asan_rel_ng   chromium_presubmit   chromeos_daisy_chromium_compile_only_ng   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_linux   linux_android_rel_ng   cast_shell_android   android_cronet   android_n5x_swarming_rel   android_compile_dbg   android_arm64_dbg_recipe   android_clang_dbg_recipe   win_clang   win_chromium_x64_rel_ng   win_chromium_rel_ng   win_chromium_compile_dbg_ng   mac_chromium_compile_dbg_ng   mac_chromium_rel_ng   ios-simulator-xcode-clang   ios-simulator   ios-device-xcode-clang   ios-device   linux_chromium_tsan_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_rel_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_chromeos_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   chromeos_daisy_chromium_compile_only_ng   linux_chromium_asan_rel_ng   chromium_presubmit   android_cronet   linux_android_rel_ng   cast_shell_linux   android_n5x_swarming_rel   cast_shell_android   android_clang_dbg_recipe   android_compile_dbg   android_arm64_dbg_recipe 
Commit queue not available (can’t edit this change).

Messages

Total messages: 13 (9 generated)
fdoray
Please take a look.
1 month, 1 week ago (2017-05-17 14:15:20 UTC) #7
Charlie Reis (slow)
LGTM
1 month, 1 week ago (2017-05-17 21:09:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886883003/1
1 month, 1 week ago (2017-05-18 12:17:39 UTC) #10
commit-bot: I haz the power
1 month, 1 week ago (2017-05-18 14:11:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/26f887dbd762f7f1b802cb70dd4d...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 23e94e589