Refactor audioparam-testing.js

Refactor audioparam-testing.js

This CL refactors audioparam-testing.js so we can hide global variables
and functions from the window scope.

BUG=722884
TEST=(All layout tests passes after this change.)

Review-Url: https://codereview.chromium.org/2886883002
Cr-Commit-Position: refs/heads/master@{#472202}
Committed: https://chromium.googlesource.com/chromium/src/+/37ca59f82e27b113196d8427acade1b5f04b0f8b

[hongchan, 2017-05-16 17:43:28]

hongchan@chromium.org changed reviewers:
+ rtoy@chromium.org

[hongchan, 2017-05-16 17:43:29]

PTAL.

Once this passes the review, I will tidy this file and land it.

[Raymond Toy, 2017-05-16 18:03:45]

lgtm with nits

https://codereview.chromium.org/2886883002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/resources/audioparam-testing.js
(right):

https://codereview.chromium.org/2886883002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/resources/audioparam-testing.js:522:
'timeConstant': .03 / 3,
This was previously computed from timeInterval.  I think we should preserve
that.

[hongchan, 2017-05-16 18:10:07]

https://codereview.chromium.org/2886883002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/resources/audioparam-testing.js
(right):

https://codereview.chromium.org/2886883002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/resources/audioparam-testing.js:522:
'timeConstant': .03 / 3,
On 2017/05/16 18:03:45, Raymond Toy wrote:
> This was previously computed from timeInterval.  I think we should preserve
> that.

I can certainly do that, but it does not add much of value since it is almost
alway will be overriden by the actual test code.

Here I am assigning values, but it is more for the sake of declaration.

[hongchan, 2017-05-16 18:10:16]

The CQ bit was checked by hongchan@chromium.org

[hongchan, 2017-05-16 18:10:17]

The patchset sent to the CQ was uploaded after l-g-t-m from rtoy@chromium.org
Link to the patchset: https://codereview.chromium.org/2886883002/#ps20001
(title: "Addressed feedback + Tidy")

[commit-bot: I haz the power, 2017-05-16 18:11:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 20:15:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494958216693250,
"parent_rev": "7b350bad16013dbcd2d827072ae7827f0c36a005", "commit_rev":
"37ca59f82e27b113196d8427acade1b5f04b0f8b"}

[commit-bot: I haz the power, 2017-05-16 20:15:24]

Description was changed from

==========
Refactor audioparam-testing.js

This CL refactors audioparam-testing.js so we can hide global variables
and functions from the window scope.

BUG=722884
TEST=(All layout tests passes after this change.)
==========

to

==========
Refactor audioparam-testing.js

This CL refactors audioparam-testing.js so we can hide global variables
and functions from the window scope.

BUG=722884
TEST=(All layout tests passes after this change.)

Review-Url: https://codereview.chromium.org/2886883002
Cr-Commit-Position: refs/heads/master@{#472202}
Committed:
https://chromium.googlesource.com/chromium/src/+/37ca59f82e27b113196d8427acad...
==========

[commit-bot: I haz the power, 2017-05-16 20:15:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/37ca59f82e27b113196d8427acad...