[kernel] Streaming ScopeBuilder

pkg/kernel/binary.md

Index: pkg/kernel/binary.md
diff --git a/pkg/kernel/binary.md b/pkg/kernel/binary.md
index 5f3d560e2364238198ac61ac0bdee458ccfdcede..9de95fbd680806950c7573641dd0ad6c6c263738 100644
--- a/pkg/kernel/binary.md
+++ b/pkg/kernel/binary.md
@@ -222,6 +222,7 @@ type Field extends Member {
   FileOffset fileOffset;
   FileOffset fileEndOffset;
   Byte flags (isFinal, isConst, isStatic);
+  UInt parentPosition; // Byte offset in the binary for the parent class, or 0 if parent is not a class.

[Kevin Millikin (Google), 2017/06/12 08:25:14]

Put the comment before the field and wrap it to 80 characters (also below).

[jensj, 2017/06/13 09:41:02]

Done.

   Name name;
   // An absolute path URI to the .dart file from which the field was created.
   UriReference fileUri;
@@ -236,6 +237,7 @@ type Constructor extends Member {
   FileOffset fileOffset;
   FileOffset fileEndOffset;
   Byte flags (isConst, isExternal);
+  UInt parentPosition; // Byte offset in the binary for the parent class.
   Name name;
   List<Expression> annotations;
   FunctionNode function;
@@ -259,6 +261,7 @@ type Procedure extends Member {
   FileOffset fileEndOffset;
   Byte kind; // Index into the ProcedureKind enum above.
   Byte flags (isStatic, isAbstract, isExternal, isConst);
+  UInt parentPosition; // Byte offset in the binary for the parent class, or 0 if parent is not a class.
   Name name;
   // An absolute path URI to the .dart file from which the class was created.
   UriReference fileUri;
@@ -307,7 +310,7 @@ enum AsyncMarker {
 */
 
 type FunctionNode {
-  // Note: there is no tag on FunctionNode.
+  Byte tag = 3;
   FileOffset fileOffset;
   FileOffset fileEndOffset;
   Byte asyncMarker; // Index into AsyncMarker above.
@@ -352,7 +355,7 @@ type InvalidExpression extends Expression {
 type VariableGet extends Expression {
   Byte tag = 20;
   FileOffset fileOffset;
-  UInt variableDeclarationPosition; // Byte offset in the binary for the variable declaration.
+  UInt variableDeclarationPosition; // Byte offset in the binary for the variable declaration (without tag).
   VariableReference variable;
 }
 
@@ -360,13 +363,13 @@ type SpecializedVariableGet extends Expression {
   Byte tag = 128 + N; // Where 0 <= N < 8.
   // Equivalent to a VariableGet with index N.
   FileOffset fileOffset;
-  UInt variableDeclarationPosition; // Byte offset in the binary for the variable declaration.
+  UInt variableDeclarationPosition; // Byte offset in the binary for the variable declaration (without tag).
 }
 
 type VariableSet extends Expression {
   Byte tag = 21;
   FileOffset fileOffset;
-  UInt variableDeclarationPosition; // Byte offset in the binary for the variable declaration.
+  UInt variableDeclarationPosition; // Byte offset in the binary for the variable declaration (without tag).
   VariableReference variable;
   Expression value;
 }
@@ -374,7 +377,7 @@ type VariableSet extends Expression {
 type SpecializedVariableSet extends Expression {
   Byte tag = 136 + N; // Where 0 <= N < 8.
   FileOffset fileOffset;
-  UInt variableDeclarationPosition; // Byte offset in the binary for the variable declaration.
+  UInt variableDeclarationPosition; // Byte offset in the binary for the variable declaration (without tag).
   Expression value;
   // Equivalent to VariableSet with index N.
 }