Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Issue 2886873006: Add logging events for auto-always, auto-never (new translate infobar) (Closed)

Created:
3 years, 7 months ago by Marti Wong
Modified:
3 years, 7 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org, asvitkine+watch_chromium.org, dfalcantara+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add logging events for auto-always, auto-never (new translate infobar) 1. log the auto-always event. (triggered when translated counter reaches a threshold) 2. log the auto-never event. (triggered when denied counter reaches a threshold) 3. log the cancel clicks of the 2 events above. BUG=720231 Review-Url: https://codereview.chromium.org/2886873006 Cr-Commit-Position: refs/heads/master@{#472655} Committed: https://chromium.googlesource.com/chromium/src/+/9121a4ac27246ad626607d10ae1009b29b20f858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java View 3 chunks +15 lines, -6 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Marti Wong
PTAL thx
3 years, 7 months ago (2017-05-17 07:11:42 UTC) #3
ramyasharma
lgtm
3 years, 7 months ago (2017-05-17 07:16:08 UTC) #4
Marti Wong
PTAL. thanks in advance!
3 years, 7 months ago (2017-05-17 07:17:57 UTC) #6
mdjones
lgtm
3 years, 7 months ago (2017-05-17 15:37:36 UTC) #7
Ilya Sherman
On 2017/05/17 07:17:57, Marti Wong wrote: > PTAL. thanks in advance! You don't need my ...
3 years, 7 months ago (2017-05-17 19:20:45 UTC) #8
Marti Wong
On 2017/05/17 19:20:45, Ilya Sherman wrote: > On 2017/05/17 07:17:57, Marti Wong wrote: > > ...
3 years, 7 months ago (2017-05-17 23:41:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886873006/1
3 years, 7 months ago (2017-05-17 23:43:12 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 04:08:24 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9121a4ac27246ad626607d10ae10...

Powered by Google App Engine
This is Rietveld 408576698