Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Issue 2886873004: Fix LogDog viewer in unstable Chrome. (Closed)

Created:
3 years, 7 months ago by dnj
Modified:
3 years, 7 months ago
Reviewers:
Ryan Tseng, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Fix LogDog viewer in unstable Chrome. Address a possible bug in upstream Chrome JavaScript engine that caused incorrect binding of "this". We fix this by coding the "appendBlock" function as a formal member function instead of an inline arrow function. BUG=chromium:722541 TEST=local R=hinoka@chromium.org Review-Url: https://codereview.chromium.org/2886873004 Committed: https://github.com/luci/luci-go/commit/205d5943440077441f141c12f2b0e6d54dc6a26d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -12 lines) Patch
M web/inc/logdog-stream-view/model.ts View 3 chunks +21 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dnj
3 years, 7 months ago (2017-05-17 00:22:37 UTC) #1
Ryan Tseng
lgtm it appears to do the exact same thing
3 years, 7 months ago (2017-05-17 00:25:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886873004/1
3 years, 7 months ago (2017-05-17 00:26:08 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 00:33:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/205d5943440077441f141c12f2b0e6d54dc6a26d

Powered by Google App Engine
This is Rietveld 408576698