[i18n] use Polymer data binding to change locale strings

chrome/test/data/webui/i18n_behavior_test.html

Index: chrome/test/data/webui/i18n_behavior_test.html
diff --git a/chrome/test/data/webui/i18n_behavior_test.html b/chrome/test/data/webui/i18n_behavior_test.html
index 0bd41fd844a132997550f218ad2cce148c25ec27..bcbad9a1f985315348e475d4578e8d520c4902e0 100644
--- a/chrome/test/data/webui/i18n_behavior_test.html
+++ b/chrome/test/data/webui/i18n_behavior_test.html
@@ -35,11 +35,17 @@ function testI18nAdvanced() {
   I18nBehavior.i18nAdvanced('customTag', {tags: ['X-FOO']});
 }
 
+function testI18nDynamic() {
+  var locale = 'en';
+  assertEquals("I'm just text, nobody should have a problem with me!",

[xiyuan, 2017/05/31 15:38:41]

nit: " -> ' ?

[dschuyler, 2017/05/31 18:23:16]

I could go either way on this, but there does seem to be a consistent pattern of
using "" if there is a ' in the string. e.g. lines 10 and 13 above. If ya have a
strong preference for only using  '' strings, I'd go ahead and change lines 10
and 13 too. If it's not too important, I'd leave it as is. wdyt?

[xiyuan, 2017/05/31 18:31:50]

Both JS style guides (google or chromium) prefer ' over " and do not mention the
exception of having a ' in the string literal.

https://google.github.io/styleguide/javascriptguide.xml?showone=Strings#Strings
https://chromium.googlesource.com/chromium/src/+/master/styleguide/web/web.md...

Anyway, I don't feel strongly about this. It is a nit so you can leave it as-is.

+      I18nBehavior.i18nDynamic(locale, 'text'));
+}

[Dan Beam, 2017/05/24 02:08:45]

hmmmm, seems like we could make a more comprehensive test.  it doesn't
necessarily have to create an OOBE UI, but it does seem like we could continue
to use I18nBehavior statically or [preferably] make a PolymerElement that has
behaviors: [I18nBehavior] and use this in conjunction with
loadTimeData.overrideValues({language: '...'}) and call i18nUpdateLocale() (or
just set locale = directly)

[dschuyler, 2017/05/31 18:23:16]

I plan to follow up on this later (tests and the future of i18n+loadTimeData).

+
 function testI18nExists() {
   assertTrue(I18nBehavior.i18nExists('text'));
   assertFalse(I18nBehavior.i18nExists('missingText'));
 }
- 
+
 </script>
 </body>
 </html>