chrome/test/data/webui/i18n_behavior_test.html - Issue 2886843005: [i18n] use Polymer data binding to change locale strings

Side by Side Diff: chrome/test/data/webui/i18n_behavior_test.html

Issue 2886843005: [i18n] use Polymer data binding to change locale strings (Closed)

Patch Set: i18nDynamic test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <body>	3 <body>

4 <script>	4 <script>

5	5

6 function setUpPage() {	6 function setUpPage() {

7 loadTimeData.data = {	7 loadTimeData.data = {

8 'allowedByDefault': '<a href="https://google.com">Google!</a>',	8 'allowedByDefault': '<a href="https://google.com">Google!</a>',

9 'customAttr': '<a is="action-link">Take action!</a>',	9 'customAttr': '<a is="action-link">Take action!</a>',

10 'customTag': "<x-foo>I'm an X, foo!</x-foo>",	10 'customTag': "<x-foo>I'm an X, foo!</x-foo>",

(...skipping 17 matching lines...) Expand all Loading...
28 I18nBehavior.i18nAdvanced('customAttr', {	28 I18nBehavior.i18nAdvanced('customAttr', {

29 attrs: {	29 attrs: {

30 is: function(el, val) {	30 is: function(el, val) {

31 return el.tagName == 'A' && val == 'action-link';	31 return el.tagName == 'A' && val == 'action-link';

32 },	32 },

33 },	33 },

34 });	34 });

35 I18nBehavior.i18nAdvanced('customTag', {tags: ['X-FOO']});	35 I18nBehavior.i18nAdvanced('customTag', {tags: ['X-FOO']});

36 }	36 }

37	37

	38 function testI18nDynamic() {

	39 var locale = 'en';

	40 assertEquals("I'm just text, nobody should have a problem with me!",
	xiyuan 2017/05/31 15:38:41 nit: " -> ' ? nit: " -> ' ? dschuyler 2017/05/31 18:23:16 I could go either way on this, but there does seem Show quoted text On 2017/05/31 15:38:41, xiyuan wrote: > nit: " -> ' ? I could go either way on this, but there does seem to be a consistent pattern of using "" if there is a ' in the string. e.g. lines 10 and 13 above. If ya have a strong preference for only using '' strings, I'd go ahead and change lines 10 and 13 too. If it's not too important, I'd leave it as is. wdyt? xiyuan 2017/05/31 18:31:50 Both JS style guides (google or chromium) prefer ' Show quoted text On 2017/05/31 18:23:16, dschuyler wrote: > On 2017/05/31 15:38:41, xiyuan wrote: > > nit: " -> ' ? > > I could go either way on this, but there does seem to be a consistent pattern of > using "" if there is a ' in the string. e.g. lines 10 and 13 above. If ya have a > strong preference for only using '' strings, I'd go ahead and change lines 10 > and 13 too. If it's not too important, I'd leave it as is. wdyt? Both JS style guides (google or chromium) prefer ' over " and do not mention the exception of having a ' in the string literal. https://google.github.io/styleguide/javascriptguide.xml?showone=Strings#Strings https://chromium.googlesource.com/chromium/src/+/master/styleguide/web/web.md... Anyway, I don't feel strongly about this. It is a nit so you can leave it as-is.
	41 I18nBehavior.i18nDynamic(locale, 'text'));

	42 }
	Dan Beam 2017/05/24 02:08:45 hmmmm, seems like we could make a more comprehensi hmmmm, seems like we could make a more comprehensive test. it doesn't necessarily have to create an OOBE UI, but it does seem like we could continue to use I18nBehavior statically or [preferably] make a PolymerElement that has behaviors: [I18nBehavior] and use this in conjunction with loadTimeData.overrideValues({language: '...'}) and call i18nUpdateLocale() (or just set locale = directly) dschuyler 2017/05/31 18:23:16 I plan to follow up on this later (tests and the f Show quoted text On 2017/05/24 02:08:45, Dan Beam wrote: > hmmmm, seems like we could make a more comprehensive test. it doesn't > necessarily have to create an OOBE UI, but it does seem like we could continue > to use I18nBehavior statically or [preferably] make a PolymerElement that has > behaviors: [I18nBehavior] and use this in conjunction with > loadTimeData.overrideValues({language: '...'}) and call i18nUpdateLocale() (or > just set locale = directly) I plan to follow up on this later (tests and the future of i18n+loadTimeData).
	43

38 function testI18nExists() {	44 function testI18nExists() {

39 assertTrue(I18nBehavior.i18nExists('text'));	45 assertTrue(I18nBehavior.i18nExists('text'));

40 assertFalse(I18nBehavior.i18nExists('missingText'));	46 assertFalse(I18nBehavior.i18nExists('missingText'));

41 }	47 }

42	48

43 </script>	49 </script>

44 </body>	50 </body>

45 </html>	51 </html>

OLD	NEW

« no previous file with comments | « chrome/browser/resources/chromeos/login/oobe_welcome.js ('k') | ui/webui/resources/js/i18n_behavior.js » ('j') | no next file with comments »