Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2886843004: Fix jittering cursor in screen magnifier mode (Closed)

Created:
3 years, 7 months ago by weidongg
Modified:
3 years, 7 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix jittering cursor in screen magnifier mode The cursor is moved back to original position after animation of zoom in and zoom out in screen magnifier mode. Moving cursor across the displays will cause the cursor to move around the border of the displays. This CL fixes this issue by leaving the cursor unchanged after animation caused by root window switch. BUG=709683 TEST=ash_unittests --gtest_filter=MagnificationControllerTest.MoveMouseToSecondDisplay Review-Url: https://codereview.chromium.org/2886843004 Cr-Commit-Position: refs/heads/master@{#472664} Committed: https://chromium.googlesource.com/chromium/src/+/2e1f4b7afbcd7917c8a577e8a47ea02e920590c2

Patch Set 1 #

Patch Set 2 : Fix unstable cursor in dual-display magnified mode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -10 lines) Patch
M ash/magnifier/magnification_controller.cc View 7 chunks +19 lines, -10 lines 0 comments Download
M ash/magnifier/magnification_controller_unittest.cc View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
weidongg
3 years, 7 months ago (2017-05-17 04:40:28 UTC) #4
weidongg
3 years, 7 months ago (2017-05-17 04:40:29 UTC) #5
Daniel Erat
is it possible to add a unit test for this? i'll be out for the ...
3 years, 7 months ago (2017-05-17 13:26:59 UTC) #8
weidongg
On 2017/05/17 13:26:59, Daniel Erat wrote: > is it possible to add a unit test ...
3 years, 7 months ago (2017-05-17 18:06:52 UTC) #9
Daniel Erat
lgtm
3 years, 7 months ago (2017-05-18 03:15:44 UTC) #11
weidongg
On 2017/05/18 03:15:44, Daniel Erat wrote: > lgtm Thanks for code review!
3 years, 7 months ago (2017-05-18 03:52:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886843004/20001
3 years, 7 months ago (2017-05-18 03:53:04 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 04:31:10 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2e1f4b7afbcd7917c8a577e8a47e...

Powered by Google App Engine
This is Rietveld 408576698