Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2886733003: Add more no-compile test for UMA_HISTOGRAM_ENUMERATION (Closed)

Created:
3 years, 7 months ago by wychen
Modified:
3 years, 7 months ago
Reviewers:
dcheng
CC:
chromium-reviews, danakj+watch_chromium.org, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more no-compile test for UMA_HISTOGRAM_ENUMERATION BUG=661401 Review-Url: https://codereview.chromium.org/2886733003 Cr-Commit-Position: refs/heads/master@{#472341} Committed: https://chromium.googlesource.com/chromium/src/+/9e472e822debee5894442de2b77dfd46d0ae9547

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M base/metrics/histogram_unittest.nc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
wychen
PTAL
3 years, 7 months ago (2017-05-16 23:20:00 UTC) #2
dcheng
lgtm
3 years, 7 months ago (2017-05-17 04:10:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886733003/1
3 years, 7 months ago (2017-05-17 05:12:36 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 05:34:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9e472e822debee5894442de2b77d...

Powered by Google App Engine
This is Rietveld 408576698