Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: chrome/browser/android/ntp/suggestions_event_reporter_bridge.cc

Issue 2886723002: [Zine] Add a metric to record number of visible sections on NTP. (Closed)
Patch Set: isherman@ nit. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/ntp/suggestions_event_reporter_bridge.cc
diff --git a/chrome/browser/android/ntp/suggestions_event_reporter_bridge.cc b/chrome/browser/android/ntp/suggestions_event_reporter_bridge.cc
index 099553cd16ef2d9a995f1457bd3323e44aaf88c2..aa3703addbe10fe87b4195b1995a4abbbac363eb 100644
--- a/chrome/browser/android/ntp/suggestions_event_reporter_bridge.cc
+++ b/chrome/browser/android/ntp/suggestions_event_reporter_bridge.cc
@@ -65,7 +65,8 @@ static void OnPageShown(
JNIEnv* env,
const JavaParamRef<jclass>& caller,
const JavaParamRef<jintArray>& jcategories,
- const JavaParamRef<jintArray>& jsuggestions_per_category) {
+ const JavaParamRef<jintArray>& jsuggestions_per_category,
+ jint j_visible_categories_count) {
std::vector<int> categories_int;
JavaIntArrayToIntVector(env, jcategories, &categories_int);
std::vector<int> suggestions_per_category_int;
@@ -78,7 +79,8 @@ static void OnPageShown(
std::make_pair(Category::FromIDValue(categories_int[i]),
suggestions_per_category_int[i]));
}
- ntp_snippets::metrics::OnPageShown(suggestions_per_category);
+ ntp_snippets::metrics::OnPageShown(suggestions_per_category,
+ j_visible_categories_count);
GetUserClassifier()->OnEvent(UserClassifier::Metric::NTP_OPENED);
}

Powered by Google App Engine
This is Rietveld 408576698