chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporterBridge.java - Issue 2886723002: [Zine] Add a metric to record number of visible sections on NTP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporterBridge.java

Issue 2886723002: [Zine] Add a metric to record number of visible sections on NTP. (Closed)

Patch Set: isherman@ nit. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporter.java ('k') | chrome/browser/android/ntp/suggestions_event_reporter_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporterBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporterBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporterBridge.java

index e16dded73493103039a3533abcc157b57ad073c1..21a1978512636b05973f72229cd93e74991e3455 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporterBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporterBridge.java

@@ -20,8 +20,9 @@ public class SuggestionsEventReporterBridge implements SuggestionsEventReporter

}

@Override

- public void onPageShown(int[] categories, int[] suggestionsPerCategory) {

- nativeOnPageShown(categories, suggestionsPerCategory);

+ public void onPageShown(

+ int[] categories, int[] suggestionsPerCategory, int visibleCategoriesCount) {

+ nativeOnPageShown(categories, suggestionsPerCategory, visibleCategoriesCount);

}

@Override

@@ -86,7 +87,8 @@ public class SuggestionsEventReporterBridge implements SuggestionsEventReporter

nativeOnColdStart();

}

- private static native void nativeOnPageShown(int[] categories, int[] suggestionsPerCategory);

+ private static native void nativeOnPageShown(

+ int[] categories, int[] suggestionsPerCategory, int visibleCategoriesCount);

private static native void nativeOnSuggestionShown(int globalPosition, int category,

int positionInCategory, long publishTimestampMs, float score, long fetchTimestampMs);

private static native void nativeOnSuggestionOpened(int globalPosition, int category,