Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2886683002: Move ValidationMessageClientImpl to core/page/. (Closed)

Created:
3 years, 7 months ago by slangley
Modified:
3 years, 7 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ValidationMessageClientImpl to core/page/. In the future this can likely be refactored with ValidationMessageClient. BUG=708879 Review-Url: https://codereview.chromium.org/2886683002 Cr-Commit-Position: refs/heads/master@{#472419} Committed: https://chromium.googlesource.com/chromium/src/+/fd3a1679f2093e60412b93e59c14bb720e306c3d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -257 lines) Patch
M third_party/WebKit/Source/core/page/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/page/ValidationMessageClientImpl.h View 2 chunks +3 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/web/ValidationMessageClientImpl.h View 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp View 1 chunk +0 lines, -168 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
slangley
3 years, 7 months ago (2017-05-16 05:03:42 UTC) #3
tkent
lgtm
3 years, 7 months ago (2017-05-16 05:06:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886683002/1
3 years, 7 months ago (2017-05-16 06:41:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/455544)
3 years, 7 months ago (2017-05-16 08:09:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886683002/1
3 years, 7 months ago (2017-05-16 10:18:25 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/455678)
3 years, 7 months ago (2017-05-16 11:56:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886683002/1
3 years, 7 months ago (2017-05-16 22:54:44 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/456600)
3 years, 7 months ago (2017-05-17 01:25:20 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886683002/1
3 years, 7 months ago (2017-05-17 07:05:22 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 11:07:06 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fd3a1679f2093e60412b93e59c14...

Powered by Google App Engine
This is Rietveld 408576698