Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2886663002: DataSaver support for off-main-thread-fetch (Closed)

Created:
3 years, 7 months ago by horo
Modified:
3 years, 7 months ago
Reviewers:
kinuko
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, mlamouri+watch-content_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org, blink-reviews, darin-cc_chromium.org, kinuko+watch, tzik, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DataSaver support for off-main-thread-fetch This CL gets the DataSaver setting on the main thread and pass it to WebWorkerFetchContext (WorkerFetchContextImpl, ServiceWorkerFetchContextImpl). WorkerFetchContext::AddAdditionalRequestHeaders() will check the flag on the worker thread and set "Save-Data" header if enabled. BUG=443374, 722774 Review-Url: https://codereview.chromium.org/2886663002 Cr-Commit-Position: refs/heads/master@{#472288} Committed: https://chromium.googlesource.com/chromium/src/+/137e05d0105abedb195dae64225b1f7b954da5e5

Patch Set 1 #

Patch Set 2 : rebase on https://codereview.chromium.org/2881073003#ps60001 #

Patch Set 3 : rebase on https://codereview.chromium.org/2881073003/#ps80001 #

Patch Set 4 : rebase on TOT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -5 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M content/renderer/service_worker/service_worker_fetch_context_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/service_worker/service_worker_fetch_context_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M content/renderer/service_worker/worker_fetch_context_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/service_worker/worker_fetch_context_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/fetch/chromium/data-saver-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerFetchContext.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/DedicatedWorkerMessagingProxyProviderImpl.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 2 3 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebWorkerFetchContext.h View 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 27 (23 generated)
horo
kinuko@ Could you please review this?
3 years, 7 months ago (2017-05-16 14:43:52 UTC) #19
kinuko
lgtm
3 years, 7 months ago (2017-05-17 02:12:45 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886663002/80001
3 years, 7 months ago (2017-05-17 02:19:04 UTC) #24
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 02:28:25 UTC) #27
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/137e05d0105abedb195dae64225b...

Powered by Google App Engine
This is Rietveld 408576698