DevTools: do not kill breakpoints in case of persistence and auto-reconnecting target.

DevTools: do not kill breakpoints in case of persistence and auto-reconnecting target.

The investigation revealed:
- BreakpointManager does not know how to set breakpoints in the UISourceCodes
  with exact URLs. For this reason, breakpoints are removed inside workers
  in case of multilpe workers launched with the same URL.
- node.js reports file URLs which clash with the file URLs from persistence.
  This provokes the same illicit behavior in BreakpointManager.
- the same would happen with file-url web sites with persistence folder

This behavior is a conceptual issue of BreakpointManager, which is relied
upon in different parts of BreakpointManager.

Given the poor state of the things in the BreakpointManager, this patch
suggests a trade-off solution for the issue:
- it is localized to persistence only
- it is localized to the case of URL collisition between FileSystem and
  network URLs

Unfortunately, the attempts to write a test with workers failed due to the
BreakpointManager's poor handling of breakpoints in workers.

BUG=722636
R=dgozman

Review-Url: https://codereview.chromium.org/2886643002
Cr-Commit-Position: refs/heads/master@{#472196}
Committed: https://chromium.googlesource.com/chromium/src/+/35cd140e98c00020451a605fe01fad753b3bed33

[lushnikov, 2017-05-16 00:56:25]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 00:57:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 02:07:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 02:07:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2017-05-16 16:43:07]

please, take a look

[lushnikov, 2017-05-16 16:43:13]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 16:43:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 18:20:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 18:20:20]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-05-16 18:52:39]

lgtm

[lushnikov, 2017-05-16 18:56:58]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-05-16 18:58:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 19:49:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494961018314820, "parent_rev":
"875a2fa43caab0ee82efe68fb5adb357392434ad", "commit_rev":
"35cd140e98c00020451a605fe01fad753b3bed33"}

[commit-bot: I haz the power, 2017-05-16 19:49:38]

Description was changed from

==========
DevTools: do not kill breakpoints in case of persistence and auto-reconnecting
target.

The investigation revealed:
- BreakpointManager does not know how to set breakpoints in the UISourceCodes
  with exact URLs. For this reason, breakpoints are removed inside workers
  in case of multilpe workers launched with the same URL.
- node.js reports file URLs which clash with the file URLs from persistence.
  This provokes the same illicit behavior in BreakpointManager.
- the same would happen with file-url web sites with persistence folder

This behavior is a conceptual issue of BreakpointManager, which is relied
upon in different parts of BreakpointManager.

Given the poor state of the things in the BreakpointManager, this patch
suggests a trade-off solution for the issue:
- it is localized to persistence only
- it is localized to the case of URL collisition between FileSystem and
  network URLs

Unfortunately, the attempts to write a test with workers failed due to the
BreakpointManager's poor handling of breakpoints in workers.

BUG=722636
R=dgozman
==========

to

==========
DevTools: do not kill breakpoints in case of persistence and auto-reconnecting
target.

The investigation revealed:
- BreakpointManager does not know how to set breakpoints in the UISourceCodes
  with exact URLs. For this reason, breakpoints are removed inside workers
  in case of multilpe workers launched with the same URL.
- node.js reports file URLs which clash with the file URLs from persistence.
  This provokes the same illicit behavior in BreakpointManager.
- the same would happen with file-url web sites with persistence folder

This behavior is a conceptual issue of BreakpointManager, which is relied
upon in different parts of BreakpointManager.

Given the poor state of the things in the BreakpointManager, this patch
suggests a trade-off solution for the issue:
- it is localized to persistence only
- it is localized to the case of URL collisition between FileSystem and
  network URLs

Unfortunately, the attempts to write a test with workers failed due to the
BreakpointManager's poor handling of breakpoints in workers.

BUG=722636
R=dgozman

Review-Url: https://codereview.chromium.org/2886643002
Cr-Commit-Position: refs/heads/master@{#472196}
Committed:
https://chromium.googlesource.com/chromium/src/+/35cd140e98c00020451a605fe01f...
==========

[commit-bot: I haz the power, 2017-05-16 19:49:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/35cd140e98c00020451a605fe01f...