Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10263)

Unified Diff: chrome/test/data/extensions/api_test/executescript/frame_id/test.js

Issue 2886633002: [Extension Bindings] Update ExecuteScriptApiTest.ExecuteScriptByFrameId (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/executescript/frame_id/test.js
diff --git a/chrome/test/data/extensions/api_test/executescript/frame_id/test.js b/chrome/test/data/extensions/api_test/executescript/frame_id/test.js
index 6fa3f36ce8f0abde9a9b3527e90384f0bd02293b..b3a8e81197ef0fc90173aa6573137f3239904eb4 100644
--- a/chrome/test/data/extensions/api_test/executescript/frame_id/test.js
+++ b/chrome/test/data/extensions/api_test/executescript/frame_id/test.js
@@ -244,9 +244,15 @@ function runTests(config) {
'executeScript should never have been executed!');
});
} catch (e) {
- assertEq(
- 'Invalid value for argument 2. Property \'frameId\': ' +
- 'Value must not be less than 0.',
+ assertTrue(
+ e.message == 'Invalid value for argument 2. Property \'frameId\':' +
lazyboy 2017/05/20 01:51:54 Here and below: add a comment saying which binding
Devlin 2017/05/23 22:29:56 Done.
+ ' Value must not be less than 0.' ||
+ e.message == 'Error in invocation of tabs.executeScript(' +
+ 'optional integer tabId, ' +
+ 'extensionTypes.InjectDetails details, ' +
+ 'optional function callback): Error at parameter ' +
+ '\'details\': Error at property \'frameId\': ' +
+ 'Value must be at least 0.',
e.message);
chrome.test.succeed();
}
@@ -367,9 +373,15 @@ function runTests(config) {
chrome.test.fail('insertCSS should never have been executed!');
});
} catch (e) {
- assertEq(
- 'Invalid value for argument 2. Property \'frameId\': ' +
- 'Value must not be less than 0.',
+ assertTrue(
+ e.message == 'Invalid value for argument 2. Property \'frameId\':' +
+ ' Value must not be less than 0.' ||
+ e.message == 'Error in invocation of tabs.insertCSS(' +
+ 'optional integer tabId, ' +
+ 'extensionTypes.InjectDetails details, ' +
+ 'optional function callback): Error at parameter ' +
+ '\'details\': Error at property \'frameId\': ' +
+ 'Value must be at least 0.',
e.message);
chrome.test.succeed();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698