Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2886633002: [Extension Bindings] Update ExecuteScriptApiTest.ExecuteScriptByFrameId (Closed)

Created:
3 years, 7 months ago by Devlin
Modified:
3 years, 7 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extension Bindings] Update ExecuteScriptApiTest.ExecuteScriptByFrameId Update ExecuteScriptApiTest.ExecuteScriptByFrameId to pass with native bindings. This only involves updating the expected error messages. BUG=653596 TEST=ExecuteScriptApiTest.ExecuteScriptByFrameId --native-crx-bindings=1 Review-Url: https://codereview.chromium.org/2886633002 Cr-Commit-Position: refs/heads/master@{#474087} Committed: https://chromium.googlesource.com/chromium/src/+/d4957aed034b6deeb7e18a0fdb814184885c5ffa

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M chrome/test/data/extensions/api_test/executescript/frame_id/test.js View 1 2 chunks +22 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Devlin
3 years, 7 months ago (2017-05-20 01:18:54 UTC) #6
lazyboy
lgtm https://codereview.chromium.org/2886633002/diff/1/chrome/test/data/extensions/api_test/executescript/frame_id/test.js File chrome/test/data/extensions/api_test/executescript/frame_id/test.js (right): https://codereview.chromium.org/2886633002/diff/1/chrome/test/data/extensions/api_test/executescript/frame_id/test.js#newcode248 chrome/test/data/extensions/api_test/executescript/frame_id/test.js:248: e.message == 'Invalid value for argument 2. Property ...
3 years, 7 months ago (2017-05-20 01:51:54 UTC) #7
Devlin
https://codereview.chromium.org/2886633002/diff/1/chrome/test/data/extensions/api_test/executescript/frame_id/test.js File chrome/test/data/extensions/api_test/executescript/frame_id/test.js (right): https://codereview.chromium.org/2886633002/diff/1/chrome/test/data/extensions/api_test/executescript/frame_id/test.js#newcode248 chrome/test/data/extensions/api_test/executescript/frame_id/test.js:248: e.message == 'Invalid value for argument 2. Property \'frameId\':' ...
3 years, 7 months ago (2017-05-23 22:29:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886633002/20001
3 years, 7 months ago (2017-05-23 22:30:51 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 22:35:12 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d4957aed034b6deeb7e18a0fdb81...

Powered by Google App Engine
This is Rietveld 408576698