[MD settings] separate spacing of controlled-by icon and control-label

[MD settings] separate spacing of controlled-by icon and control-label

This CL replaces the use of the --cr-control-spacing with two variables
--cr--control-label-spacing and --cr-controlled-by-spacing. Those two
distances are now required (by UI) to be different values (20px and 24px
respectively). Removing the old variable and using more explicitly named
variables should help avoid confusion about where each should be used.

BUG=721230
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2886603002
Cr-Commit-Position: refs/heads/master@{#472177}
Committed: https://chromium.googlesource.com/chromium/src/+/38438a522f398efbc70717d69c8999fc13574640

[dschuyler, 2017-05-15 23:28:58]

Description was changed from

==========
[MD settings] separate spacing of controlled-by icon and control-label

This CL replaces the use of the --cr-control-spacing with two variables
--cr--control-label-spacing and --cr-controlled-by-spacing. Those two
distances are now required (by UI) to be different values (20px and 24px
respectively). Removing the old variable and using more explicitly named
variables should help avoid confusion about where each should be used.

BUG=721230
==========

to

==========
[MD settings] separate spacing of controlled-by icon and control-label

This CL replaces the use of the --cr-control-spacing with two variables
--cr--control-label-spacing and --cr-controlled-by-spacing. Those two
distances are now required (by UI) to be different values (20px and 24px
respectively). Removing the old variable and using more explicitly named
variables should help avoid confusion about where each should be used.

BUG=721230
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-05-15 23:29:01]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 23:29:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-05-15 23:32:01]

dschuyler@chromium.org changed reviewers:
+ stevenjb@chromium.org

[dschuyler, 2017-05-15 23:32:02]

The 'main change' is in ui/webui/resources/cr_elements/shared_vars_css.html
The other files are changed as a consequence of that change.

[dschuyler, 2017-05-15 23:37:41]

On 2017/05/15 23:32:02, dschuyler wrote:
> The 'main change' is in ui/webui/resources/cr_elements/shared_vars_css.html
> The other files are changed as a consequence of that change.

There are a couple screen shots at http://imgur.com/a/UTPX6 (not nearly all the
changes, let me know if you'd like more screen shots).

[stevenjb, 2017-05-15 23:40:10]

https://codereview.chromium.org/2886603002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/shared_vars_css.html (right):

https://codereview.chromium.org/2886603002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/shared_vars_css.html:12:
--cr-control-label-spacing: 20px;
Is this actually used other than on the settings_shared file? If not, maybe just
define it there?

[dschuyler, 2017-05-15 23:48:45]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 23:48:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-05-15 23:49:29]

https://codereview.chromium.org/2886603002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/shared_vars_css.html (right):

https://codereview.chromium.org/2886603002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/shared_vars_css.html:12:
--cr-control-label-spacing: 20px;
On 2017/05/15 23:40:09, stevenjb wrote:
> Is this actually used other than on the settings_shared file? If not, maybe
just
> define it there?

Done.

[stevenjb, 2017-05-15 23:54:34]

lgtm

[commit-bot: I haz the power, 2017-05-16 02:13:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 02:13:59]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-05-16 18:30:21]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2017-05-16 18:31:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 18:49:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494959421528310,
"parent_rev": "9af44404799be9d1b22b16e9e4da37ddf918b944", "commit_rev":
"38438a522f398efbc70717d69c8999fc13574640"}

[commit-bot: I haz the power, 2017-05-16 18:49:57]

Description was changed from

==========
[MD settings] separate spacing of controlled-by icon and control-label

This CL replaces the use of the --cr-control-spacing with two variables
--cr--control-label-spacing and --cr-controlled-by-spacing. Those two
distances are now required (by UI) to be different values (20px and 24px
respectively). Removing the old variable and using more explicitly named
variables should help avoid confusion about where each should be used.

BUG=721230
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] separate spacing of controlled-by icon and control-label

This CL replaces the use of the --cr-control-spacing with two variables
--cr--control-label-spacing and --cr-controlled-by-spacing. Those two
distances are now required (by UI) to be different values (20px and 24px
respectively). Removing the old variable and using more explicitly named
variables should help avoid confusion about where each should be used.

BUG=721230
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2886603002
Cr-Commit-Position: refs/heads/master@{#472177}
Committed:
https://chromium.googlesource.com/chromium/src/+/38438a522f398efbc70717d69c89...
==========

[commit-bot: I haz the power, 2017-05-16 18:50:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/38438a522f398efbc70717d69c89...