Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2886573003: Limit protection of clients[0-9]*.google.com to requests from browser. (Closed)

Created:
3 years, 7 months ago by Mike West
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Limit protection of clients[0-9]*.google.com to requests from browser. The WebRequest API protected network requests to clients[0-9]*.google.com from being visible or modified by extensions. This was built under the assumption that these domains are only used by Chrome internally, which was invalid. This CL restrictes the protection to only those network requests that originate from the browser. Requests from the renderers are exposed to extensions. BUG=715184 TEST=https://crbug.com/715184#c12 Review-Url: https://codereview.chromium.org/2845943003 Cr-Original-Commit-Position: refs/heads/master@{#470949} Review-Url: https://codereview.chromium.org/2886573003 . Cr-Commit-Position: refs/branch-heads/3071@{#578} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/210763c75ffa0245904ff82e31d6e08e5b28ed89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -36 lines) Patch
M extensions/browser/api/web_request/web_request_permissions.h View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/api/web_request/web_request_permissions.cc View 5 chunks +43 lines, -16 lines 0 comments Download
M extensions/browser/api/web_request/web_request_permissions_unittest.cc View 1 chunk +29 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Mike West
3 years, 7 months ago (2017-05-16 11:27:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
210763c75ffa0245904ff82e31d6e08e5b28ed89.

Powered by Google App Engine
This is Rietveld 408576698