|
|
Created:
3 years, 7 months ago by James Cook Modified:
3 years, 7 months ago Reviewers:
sky CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRename ash_mus_unittests builder step to "ash_unittests --mus"
This makes it less confusing for developers when a test fails. There is
no ash_mus_unittests build target. The builder step runs ash_unittests
with the --mus flag, so make that clear in the name.
BUG=none
TEST=bots
Review-Url: https://codereview.chromium.org/2886553002
Cr-Commit-Position: refs/heads/master@{#473059}
Committed: https://chromium.googlesource.com/chromium/src/+/810fb476a38bd8b678464e9ed7c05aa23096d95c
Patch Set 1 #Patch Set 2 : build file #
Messages
Total messages: 40 (29 generated)
The CQ bit was checked by jamescook@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by jamescook@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jamescook@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jamescook@chromium.org
The CQ bit was checked by jamescook@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jamescook@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
sky, please take a look. I checked the logdog, milo, and swarming web pages. They all seem happy with a test suite name with a space in it.
jamescook@chromium.org changed reviewers: + sky@chromium.org
sky, please take a look. I checked the logdog, milo, and swarming web pages. They all seem happy with a test suite name with a space in it.
Nice! LGTM
The CQ bit was checked by jamescook@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jamescook@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jamescook@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jamescook@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495161484932410, "parent_rev": "95b208fa12493944a843e67c48bf6b21499c3f6d", "commit_rev": "810fb476a38bd8b678464e9ed7c05aa23096d95c"}
Message was sent while issue was closed.
Description was changed from ========== Rename ash_mus_unittests builder step to "ash_unittests --mus" This makes it less confusing for developers when a test fails. There is no ash_mus_unittests build target. The builder step runs ash_unittests with the --mus flag, so make that clear in the name. BUG=none TEST=bots ========== to ========== Rename ash_mus_unittests builder step to "ash_unittests --mus" This makes it less confusing for developers when a test fails. There is no ash_mus_unittests build target. The builder step runs ash_unittests with the --mus flag, so make that clear in the name. BUG=none TEST=bots Review-Url: https://codereview.chromium.org/2886553002 Cr-Commit-Position: refs/heads/master@{#473059} Committed: https://chromium.googlesource.com/chromium/src/+/810fb476a38bd8b678464e9ed7c0... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/810fb476a38bd8b678464e9ed7c0... |