Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2886503002: Convert additional ozone/drm callbacks to OnceCallback (Closed)

Created:
3 years, 7 months ago by rjkroege
Modified:
3 years, 7 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert additional ozone/drm callbacks to OnceCallback Further replace base::Callback with base::OnceCallback in ozone/drm in swap buffers implementation. BUG=620927 Review-Url: https://codereview.chromium.org/2886503002 Cr-Commit-Position: refs/heads/master@{#474045} Committed: https://chromium.googlesource.com/chromium/src/+/a15746c2355c8ef9a09028465d727add7a241a69

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed the unittests #

Patch Set 3 : fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -35 lines) Patch
M ui/ozone/platform/drm/gpu/drm_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_thread.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_window.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_window.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_window_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_window_proxy.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_controller.h View 1 2 4 chunks +3 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_controller.cc View 1 1 chunk +9 lines, -9 lines 0 comments Download
M ui/ozone/platform/drm/gpu/page_flip_request.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/page_flip_request.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ui/ozone/public/swap_completion_callback.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
rjkroege
ptal
3 years, 7 months ago (2017-05-15 17:57:34 UTC) #2
dnicoara
lgtm https://codereview.chromium.org/2886503002/diff/1/ui/ozone/platform/drm/gpu/hardware_display_controller.h File ui/ozone/platform/drm/gpu/hardware_display_controller.h (right): https://codereview.chromium.org/2886503002/diff/1/ui/ozone/platform/drm/gpu/hardware_display_controller.h#newcode90 ui/ozone/platform/drm/gpu/hardware_display_controller.h:90: // typedef base::Callback<void(gfx::SwapResult)> SwapCompletionOnceCallback; nit: Delete line
3 years, 7 months ago (2017-05-15 20:22:14 UTC) #7
rjkroege
On 2017/05/15 20:22:14, dnicoara wrote: > lgtm > > https://codereview.chromium.org/2886503002/diff/1/ui/ozone/platform/drm/gpu/hardware_display_controller.h > File ui/ozone/platform/drm/gpu/hardware_display_controller.h (right): > ...
3 years, 7 months ago (2017-05-23 20:26:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886503002/40001
3 years, 7 months ago (2017-05-23 20:28:45 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 20:53:08 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a15746c2355c8ef9a09028465d72...

Powered by Google App Engine
This is Rietveld 408576698