Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2886493002: Fix isolate tests flakiness because of test_data/chrome/browser/resources/print_preview. (Closed)

Created:
3 years, 7 months ago by dpapad
Modified:
3 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix isolate tests flakiness because of test_data/chrome/browser/resources/print_preview. BUG=722123 Review-Url: https://codereview.chromium.org/2886493002 Cr-Commit-Position: refs/heads/master@{#471856} Committed: https://chromium.googlesource.com/chromium/src/+/0712667572b158d0613b5f5a2ec8fa6f61cada34

Patch Set 1 #

Patch Set 2 : More #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M chrome/test/BUILD.gn View 1 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (9 generated)
Nico
patch set 2 lgtm as far as I can tell. Thanks!
3 years, 7 months ago (2017-05-15 17:43:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886493002/20001
3 years, 7 months ago (2017-05-15 17:48:20 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 19:11:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0712667572b158d0613b5f5a2ec8...

Powered by Google App Engine
This is Rietveld 408576698